Backport #4089 renewals fix for pallet-broker #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was cherry picked and released on crates.io. No need to merge. |
|
Turns out this was only merged into the |
seadanda
changed the base branch from
release-polkadot-v1.7.2
to
release-polkadot-v1.7.3
|
The CI pipeline was cancelled due to failure one of the required jobs. |
eskimor
approved these changes
Jun 3, 2024
seadanda
added a commit
that referenced
this pull request
Jun 3, 2024
When merging the two backports (#4194 and #4656) for the broker pallet, the priority of the changes seems to have been reversed and ended up with some broken code. CI doesn't actually run before merging on these release branches so it merged with broken tests. `release-` branches are protected so it needs this PR to remove the duplication. Sorry for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4107