include events for voting #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-voting' into dami/add-events-to-pallet-conviction-voting
|
Any possibility of help getting this reviewed @muharem |
bkchr
approved these changes
Jul 3, 2024
| @@ -170,6 +170,10 @@ pub mod pallet { | |||
| Delegated(T::AccountId, T::AccountId), | |||
| /// An \[account\] has cancelled a previous delegation operation. | |||
| Undelegated(T::AccountId), | |||
| /// An account that has voted | |||
| VoteEnacted { who: T::AccountId, vote: AccountVote<BalanceOf<T, I>> }, | |||
There was a problem hiding this comment.
Suggested change
| VoteEnacted { who: T::AccountId, vote: AccountVote<BalanceOf<T, I>> }, | |
| Voted { who: T::AccountId, vote: AccountVote<BalanceOf<T, I>> }, |
Enacted sounds to me more final.
ggwpez
reviewed
Jul 3, 2024
prdoc/pr_4613.prdoc
Outdated
| @@ -0,0 +1,10 @@ | |||
| title: "Include events for vote and remove vote" | |||
There was a problem hiding this comment.
Suggested change
| title: "Include events for vote and remove vote" | |
| title: "pallet-conviction-voting: Include events for vote and remove vote" |
Otherwise the CHANGELOG will read a bit weird.
|
@dharjeezy please address the review comments, and we can get this merged |
…tion-voting' into dami/add-events-to-pallet-conviction-voting
done |
prdoc/pr_4613.prdoc
Outdated
| doc: | ||
| - audience: Runtime User | ||
| description: | | ||
| Includes event for vote and remove_vote |
There was a problem hiding this comment.
I'd mention what the fields are
muharem
reviewed
Jul 23, 2024
Co-authored-by: Muharem <ismailov.m.h@gmail.com>
|
looks good, I merge when CI pass |
muharem
approved these changes
Jul 24, 2024
Merged
via the queue into
paritytech:master
with commit Jul 24, 2024
2982bf3
155 of 159 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
closes paritytech#143 Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW --------- Co-authored-by: Muharem <ismailov.m.h@gmail.com>
ordian
added a commit
that referenced
this pull request
Aug 6, 2024
* master: (27 commits) Bridges improved tests and nits (#5128) Fix misleading comment about RewardHandler in epm config (#3095) Introduce a workflow updating the wishlist leaderboards (#5085) membership: Restructure pallet into separate files (#4536) Fix after ring-proof api change (#5126) Bump paritytech/review-bot from 2.4.0 to 2.5.0 (#5057) Bump docker/login-action from 3.0.0 to 3.3.0 (#5109) Bump docker/build-push-action from 5.1.0 to 6.5.0 (#5108) Bump peter-evans/create-pull-request from 5.0.0 to 6.1.0 (#5093) Tx Payment: drop ED requirements for tx payments with exchangeable asset (#4488) Remove `pallet-getter` usage from pallet-transaction-payment (#4970) pallet macro: do not generate try-runtime related code when frame-support doesn't have try-runtime. (#5099) fix(chain-spec): ChainSpecBuilder with object as default genesis (#4345) Migrate BEEFY BLS crypto to bls12-381 curve (#4931) Bump clap from 4.5.9 to 4.5.10 in the known_good_semver group (#5120) Use jobserver in wasm-builder to limit concurrency of spawned cargo processes (#4946) include events for voting (#4613) [subsystem-bench] Add mocks for own assignments triggering (#5042) Remove not-audited warning (#5114) hotfix: blockchain/backend: Skip genesis leaf to unblock syncing (#5103) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #143
Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW