-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeSubstitutes
to rococo parachains
#4669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked that the following code substitutes were added:
asset-hub-rococo.json:
@ ["codeSubstitutes","4960799"]
bridge-hub-rococo.json:
@ ["codeSubstitutes","3603599"]
contracts-rococo.json:
@ ["codeSubstitutes","5359899"]
coretime-rococo.json:
@ ["codeSubstitutes","1627199"]
people-rococo.json:
@ ["codeSubstitutes","1209599"]
Can we do any better in reviewing of these changes?
So basically to do the full verification your can build the runtimes for the chains in question.
These files should be the same as the bytes that were substituted in the chain-specs here. As far as the block numbers go, you should be able to see a big gap in time after these blocks in pjs. But yeah, otherwise not much to do. You can in addition verify that they are the same ones as in #4600 , which are the ones that are now live on rococo and proven to be working. |
What version of toolchain is required? So far I get runtimes of different sizes) |
This is not reproducible. You would need to use a reproducible env like |
624a1d5
Since the fix for paritytech#4559 was to add a codeSubstitute to the rococo-parachains, we should update the chain-specs in the repo. The json diffs are not super easy to review, so if you want to manually check: - Run for example `jd -o people-rococo.diff people-rococo-from-this-branch.json people-rococo-master.json` - Check in the resulting diff file that only `codeSubstitutes` field is changed
Since the fix for paritytech#4559 was to add a codeSubstitute to the rococo-parachains, we should update the chain-specs in the repo. The json diffs are not super easy to review, so if you want to manually check: - Run for example `jd -o people-rococo.diff people-rococo-from-this-branch.json people-rococo-master.json` - Check in the resulting diff file that only `codeSubstitutes` field is changed
Since the fix for #4559 was to add a codeSubstitute to the rococo-parachains, we should update the chain-specs in the repo.
The json diffs are not super easy to review, so if you want to manually check:
jd -o people-rococo.diff people-rococo-from-this-branch.json people-rococo-master.json
codeSubstitutes
field is changed