Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeSubstitutes to rococo parachains #4669

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Jun 3, 2024

Since the fix for #4559 was to add a codeSubstitute to the rococo-parachains, we should update the chain-specs in the repo.

The json diffs are not super easy to review, so if you want to manually check:

  • Run for example jd -o people-rococo.diff people-rococo-from-this-branch.json people-rococo-master.json
  • Check in the resulting diff file that only codeSubstitutes field is changed

@skunert skunert added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. T14-system_parachains This PR/Issue is related to system parachains. labels Jun 3, 2024
@skunert skunert requested a review from a team June 3, 2024 08:10
Copy link
Contributor

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that the following code substitutes were added:

asset-hub-rococo.json:
@ ["codeSubstitutes","4960799"]

bridge-hub-rococo.json:
@ ["codeSubstitutes","3603599"]

contracts-rococo.json:
@ ["codeSubstitutes","5359899"]

coretime-rococo.json:
@ ["codeSubstitutes","1627199"]

people-rococo.json:
@ ["codeSubstitutes","1209599"]

Can we do any better in reviewing of these changes?

@skunert
Copy link
Contributor Author

skunert commented Jun 3, 2024

So basically to do the full verification your can build the runtimes for the chains in question.
I used this commit: d3bf1a8
Then build the runtimes, we are interested in the .compact.compressed ones.

cargo build --release -p people-rococo-runtime -p contracts-rococo-runtime -p bridge-hub-rococo-runtime -p asset-hub-rococo-runtime -p coretime-rococo-runtime`, then the runtime wasm files are located in `target/release/wbuild

These files should be the same as the bytes that were substituted in the chain-specs here.

As far as the block numbers go, you should be able to see a big gap in time after these blocks in pjs. But yeah, otherwise not much to do. You can in addition verify that they are the same ones as in #4600 , which are the ones that are now live on rococo and proven to be working.

@dmitry-markin
Copy link
Contributor

dmitry-markin commented Jun 3, 2024

What version of toolchain is required? So far I get runtimes of different sizes)

@bkchr
Copy link
Member

bkchr commented Jun 3, 2024

These files should be the same as the bytes that were substituted in the chain-specs here.

This is not reproducible. You would need to use a reproducible env like srtool. Generally, these are test networks and I think we can trust @skunert enough to have compiled the correct code ;)

@skunert skunert added this pull request to the merge queue Jun 4, 2024
Merged via the queue into paritytech:master with commit 624a1d5 Jun 4, 2024
154 of 155 checks passed
@skunert skunert deleted the skunert/chain-spec-update branch June 4, 2024 13:25
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Since the fix for paritytech#4559
was to add a codeSubstitute to the rococo-parachains, we should update
the chain-specs in the repo.

The json diffs are not super easy to review, so if you want to manually
check:
- Run for example `jd -o people-rococo.diff
people-rococo-from-this-branch.json people-rococo-master.json`
- Check in the resulting diff file that only `codeSubstitutes` field is
changed
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Since the fix for paritytech#4559
was to add a codeSubstitute to the rococo-parachains, we should update
the chain-specs in the repo.

The json diffs are not super easy to review, so if you want to manually
check:
- Run for example `jd -o people-rococo.diff
people-rococo-from-this-branch.json people-rococo-master.json`
- Check in the resulting diff file that only `codeSubstitutes` field is
changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. T14-system_parachains This PR/Issue is related to system parachains.
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

4 participants