[HRMP] Dont partially modify pages #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
changed the title
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
muharem
approved these changes
Jun 6, 2024
bkchr
reviewed
Jun 6, 2024
| @@ -491,7 +491,7 @@ impl<T: Config> Pallet<T> { | |||
| let channel_info = | |||
| T::ChannelInfo::get_channel_info(recipient).ok_or(MessageSendError::NoChannel)?; | |||
| // Max message size refers to aggregates, or pages. Not to individual fragments. | |||
| let max_message_size = channel_info.max_message_size as usize; | |||
| let max_message_size = channel_info.max_message_size.min(T::MaxPageSize::get()) as usize; | |||
There was a problem hiding this comment.
Suggested change
| let max_message_size = channel_info.max_message_size.min(T::MaxPageSize::get()) as usize; | |
| let max_message_size = channel_info.max_message_size.min.saturating_add(XcmpMessageFormat::max_encoded_len())(T::MaxPageSize::get()) as usize; |
The XcmpMessageFormat is part of the page. So, if we don't do this, we will never be able to storage a message of max_message_size (when this is smaller than T::MaxPageSize).
There was a problem hiding this comment.
Yes, but i think this is a hard limit from the relay chain that we cannot go over. So the "max message size" is for a HRMP message - not for the XCM inside of it.
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Changes: - The XCMP queue does not partially modify pages anymore by using `try_mutate` instead of `mutate`. - The XCMP queue max page size is now the min between the value that the relay reports and the local limit. Thanks to whom pointed this out to me via DM. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
try_mutateinstead ofmutate.Thanks to whom pointed this out to me via DM.