Remove getters from pallet-membership #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Jun 21, 2024
bkchr
reviewed
Jun 24, 2024
kianenigma
reviewed
Jun 28, 2024
kianenigma
approved these changes
Jun 28, 2024
seadanda
approved these changes
Jun 28, 2024
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
63 tasks
Merged
via the queue into
paritytech:master
with commit Jul 1, 2024
333f4c7
155 of 158 checks passed
TomaszWaszczyk
pushed a commit
to TomaszWaszczyk/polkadot-sdk
that referenced
this pull request
Jul 7, 2024
As per paritytech#3326 , removes pallet::getter macro usage from pallet-membership. The syntax StorageItem::<T, I>::get() should be used instead. Also converts some syntax to turbo and reimplements the removed getters, following paritytech#223 cc @muraca --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
As per paritytech#3326 , removes pallet::getter macro usage from pallet-membership. The syntax StorageItem::<T, I>::get() should be used instead. Also converts some syntax to turbo and reimplements the removed getters, following paritytech#223 cc @muraca --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This was referenced Aug 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3326 , removes pallet::getter macro usage from pallet-membership. The syntax StorageItem::<T, I>::get() should be used instead. Also converts some syntax to turbo and reimplements the removed getters, following #223
cc @muraca