[2 / 5] Make approval-distribution logic runnable on a separate thread #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
changed the title
6 tasks
alexggh
changed the title
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-1-5
branch
from
381e0b9
to
88e15da
Compare
alexggh
changed the title
alexggh
changed the base branch from
master
to
alexaggh/approval-voting-parallel-3-5
alexggh
changed the base branch from
alexaggh/approval-voting-parallel-3-5
to
master
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-1-5
branch
from
88e15da
to
4b3f489
Compare
alexggh
changed the title
alexggh
changed the base branch from
master
to
alexaggh/approval-voting-parallel-4-5
|
The CI pipeline was cancelled due to failure one of the required jobs. |
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-4-5
branch
from
4b3f489
to
713aef4
Compare
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-1-5
branch
2 times, most recently
from
406d11c
to
2281330
Compare
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-1-5
branch
from
2281330
to
8dbb088
Compare
sandreim
approved these changes
Jul 25, 2024
alindima
approved these changes
Jul 26, 2024
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
ordian
approved these changes
Jul 26, 2024
|
missing prdoc |
ordian
added
the
T8-polkadot
AndreiEres
approved these changes
Jul 29, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
paritytech#4845) This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading paritytech#4849 (comment), # Description This PR contain changes to make possible the run of multiple instances of approval-distribution, so that we can parallelise the work. This does not contain any functional changes it just decouples the subsystem from the subsystem Context and introduces more specific trait dependencies for each function instead of all of them requiring a context. It does not have any dependency of the follow PRs, so it can be merged independently of them. --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading #4849 (comment),
Description
This PR contain changes to make possible the run of multiple instances of approval-distribution, so that we can parallelise the work. This does not contain any functional changes it just decouples the subsystem from the subsystem Context and introduces more specific trait dependencies for each function instead of all of them requiring a context.
It does not have any dependency of the follow PRs, so it can be merged independently of them.