Add ProofSizeExt to benchmarks
#5257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
the
T12-benchmarks
1 task
I think it is both needed since it uses the proof recorder from the |
Yes. This is my impression as well. I added a CLI flag to revert to the old behaviour. By running benchmarks a few times on my machine I found that timing weight impact is around 3-9%. For parachains this is correct, but unnecessary for relay chains and solochains. |
kianenigma
approved these changes
Aug 6, 2024
lexnv
approved these changes
Aug 6, 2024
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Aug 28, 2024
I propose to have `ProofSizeExt` available during benchmarking so we can improve the accuracy for extensions using it. Another thing we could do is to also enable recording for the timing benchmark here: https://github.com/paritytech/polkadot-sdk/blob/035211d707d0a74a2a768fd658160721f09d5b44/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs#L232 Parachains will need to have recording enabled during import for reclaim, so we could enable it here and provide a flag `--disable-proof-recording` for scenarios where one does not want it. Happy to hear opinions about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to have
ProofSizeExtavailable during benchmarking so we can improve the accuracy for extensions using it.Another thing we could do is to also enable recording for the timing benchmark here:
polkadot-sdk/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
Line 232 in 035211d
Parachains will need to have recording enabled during import for reclaim, so we could enable it here and provide a flag
--disable-proof-recordingfor scenarios where one does not want it. Happy to hear opinions about this.