Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #5321 #5332

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[stable2407] Backport #5321 #5332

merged 3 commits into from
Aug 13, 2024

Conversation

alindima
Copy link
Contributor

@alindima alindima commented Aug 13, 2024 •
edited
Loading

Backports #5321 on the stable release

@alindima alindima added A3-backport Pull request is already reviewed well in another branch. I2-bug The node fails to follow expected behavior. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Aug 13, 2024
@alindima alindima changed the title [stable2407] Backport https://github.com/paritytech/polkadot-sdk/pull/5321 [stable2407] Backport #5321 Aug 13, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 4eb5f81 into stable2407 Aug 13, 2024
151 of 161 checks passed
@EgorPopelyaev EgorPopelyaev deleted the alindima/stable2407-fix-memleak branch August 13, 2024 13:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexggh alexggh alexggh approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch. I2-bug The node fails to follow expected behavior. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alindima @alexggh @sandreim @EgorPopelyaev