[Staking] Currency <> Fungible migration #5501
Conversation
balance hold checks both frozen and reserved wip: around 25 tests failing check Holds instead of locks 20 tests failing fmt 11 fails 4 fails 2 failing 1 fail all tests pass but pending a hygiene check of code fix compile minor refactor remove T::Currency calls from asset mod
Ank4n
changed the base branch from
master
to
ankan/staking-migrate-currency-to-fungible
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
…staking-migrate-currency-to-fungible-2
|
bot bench substrate-pallet --pallet=pallet_staking |
|
@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7361897 was started for your command Comment |
| @@ -131,19 +131,13 @@ impl<T: Config> AgentLedger<T> { | |||
| /// | |||
| /// Increments provider count if this is a new agent. | |||
| pub(crate) fn update(self, key: &T::AccountId) { | |||
| if !<Agents<T>>::contains_key(key) { | |||
| // This is a new agent. Provide for this account. | |||
| frame_system::Pallet::<T>::inc_providers(key); | |||
There was a problem hiding this comment.
Agents don't need provider anymore as staking account does not have consumers.
TODO: add migration for agents to dec provider.
…=dev --target_dir=substrate --pallet=pallet_staking
|
@Ank4n Command |
|
bot bench polkadot-pallet --pallet=pallet_staking --runtime=westend |
|
@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7363513 was started for your command Comment |
…=westend --target_dir=polkadot --pallet=pallet_staking
|
@Ank4n Command |
substrate/frame/treasury/src/lib.rs
Outdated
| use frame_support::traits::fungible::Balanced; | ||
| let numeric_amount = credit.peek(); | ||
|
|
||
| let _ = T::Currency::resolve(&Pallet::<T>::account_id(), credit); |
There was a problem hiding this comment.
Re-check if this is okay
Migrate staking currency from
traits::LockableCurrencytotraits::fungible::holds.Summary of changes
Currencybecomes of typeFungiblewhileOldCurrencyis theLockableCurrencyused before.migrate_currency()releases the oldlockalong with some housekeeping.Migration stats
Polkadot
Total accounts that can be migrated: 61752
Accounts failing to migrate: 1
Accounts with some stake force withdrawn: 35
Total force withdrawal: 16287.7 DOT
Kusama
Total accounts that can be migrated: 26835
Accounts failing to migrate: 0
Accounts with some stake force withdrawn: 59
Total force withdrawal: 14.5 KSM
Full logs here. Error in polkadot is caused due to the ledger corruption, will be fixed by this runtime update. It is possible some of the force withdraws are happening because of ledger corruption and the migration stats might change after those ledgers are fixed.
Note about locks (freeze) vs holds
With locks or freezes, staking could use total balance of an account. But with holds, the account needs to be left with at least Existential Deposit in free balance. This would also affect nomination pools which till now has been able to stake all funds contributed to it. An alternate version of this PR is #5658 where staking pallet does not add any provider, but means pools and delegated-staking pallet has to provide for these accounts and makes the end to end logic (of provider and consumer ref) lot less intuitive and prone to bug.
One way to handle this issue is add a provider to staking stash. This then replicates old behaviour of staking where accounts could stake their whole balance. The side effect of this is that, for stakers that have been slashed to zero, their stash may not be reaped until all consumers to this account is removed. This is because,
dec_providerwould fail untilconsumer == 0.Note about providers and consumers
Before
pallet-staking added consumers for stash account. This meant the agent/pool account must need a provider (by holding ED or system inc provider). We did an explicit inc provider for agents in pallet-delegated staking to allow consumer inc.
Now
This is more simplified.
pallet-stakingadds provider for stash accounts, but no consumer.pallet-delegated-stakingor pools does not need to add provider anymore (or consumer), and as stated before, helps retain the old behaviour of being able to stake all balance via both direct staking or pool.TODO
migrate_currency.Followup