Allow to call arbitrary runtime apis using RelayChainInterface #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Aug 29, 2024
| hash: PHash, | ||
| payload: &[u8], | ||
| ) -> RelayChainResult<Vec<u8>> { | ||
| use sp_api::{CallApiAt, CallApiAtParams, CallContext, __private::Extensions}; |
There was a problem hiding this comment.
The module is called __private out of a reason ;)
| at: hash, | ||
| function: method_name, | ||
| arguments: payload.to_vec(), | ||
| overlayed_changes: &RefCell::new(overlayed_changes), |
There was a problem hiding this comment.
Suggested change
| overlayed_changes: &RefCell::new(overlayed_changes), | |
| overlayed_changes: &RefCell::new(Default::default()), |
| @@ -364,3 +380,18 @@ where | |||
| (**self).version(relay_parent).await | |||
| } | |||
| } | |||
|
|
|||
| pub async fn call_remote_runtime_function<R>( | |||
There was a problem hiding this comment.
It saves the caller from having to manually do the Decode::decode. I can remove it if you want, but I think it's useful.
bkchr
reviewed
Aug 30, 2024
tmpolaczyk
force-pushed
the
tomasz-relaychaininterface-runtime-api
branch
from
e60932b
to
f276916
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@bkchr solved your comments, anything else missing? |
tmpolaczyk
force-pushed
the
tomasz-relaychaininterface-runtime-api
branch
from
58bad1e
to
5c19396
Compare
|
@bkchr can you help us get the CI passing? Just from a first glance I dont see anything wrong for prdoc but maybe I am missing something..., |
bkchr
approved these changes
Sep 18, 2024
skunert
approved these changes
Sep 19, 2024
Merged
via the queue into
paritytech:master
with commit Sep 20, 2024
5a43147
203 of 208 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the relay chain though a
Arc<dyn RelayChainInterface>there is no way to call arbitrary runtime apis. Both implementations of that trait allow this, so it feels natural to expose this functionality in the trait.This PR adds a
call_runtime_apimethod to RelayChainInterface trait, and a separate function also namedcall_runtime_apiwhich allows the caller to specify the input and output types, as opposed to having to encode them. This generic function cannot be part of the trait because adyn Traitobject cannot have generic methods.