Fix border condition in Snowbridge free consensus Updates #5671
+662
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* illustrates border condition * adds test payloads * cleanup * update comment * fmt * shuffle things around * a few more test checks * Update bridges/snowbridge/pallets/ethereum-client/src/lib.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
claravanstaden
changed the title
|
@acatangiu may you please add the T15-bridges label. :) |
…-fix' into snowbridge-free-consensus-update-fix
ggwpez
added
T15-bridges
|
@vgeddes @alistair-singh @yrong ready to review. :) |
claravanstaden
changed the title
acatangiu
approved these changes
Sep 13, 2024
vgeddes
approved these changes
Sep 13, 2024
|
@bkontur @serban300 please review - we also need to backport this fix. |
alistair-singh
approved these changes
Sep 19, 2024
@franciscoaguirre do you mean another test check or a check in the light client? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix for a border condition introduced with new feature #5201. A malicious relayer could spam the Ethereum client with sync committee updates that have already been imported for the period. This PR adds a storage item to track the last imported sync committee period, so that subsequent irrelevant updates are not free.
Original PR: Snowfork#172
Integration
Downstream projects are not affected. Relayers will not be able to spam the Ethereum client with irrelevant sync committee updates for free.
Review Notes
Adds a storage item to track the last free sync committee update period, so that duplicate imports are not free.