Switch node side to v2 candidate receipts #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Base automatically changed from
sandreim/runtime_v2_descriptor_support
to
master
October 7, 2024 07:22
2 tasks
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…reim/node_v2_descriptors Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
|
/cmd prdoc --audience node_dev runtime_dev --bump major |
…me_dev --bump major'
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
alindima
approved these changes
Oct 22, 2024
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
tdimitrov
approved these changes
Oct 25, 2024
| @@ -71,18 +71,15 @@ pub struct FetchedCollation { | |||
| pub para_id: ParaId, | |||
| /// Candidate hash. | |||
| pub candidate_hash: CandidateHash, | |||
| /// Id of the collator the collation was fetched from. | |||
| pub collator_id: CollatorId, | |||
There was a problem hiding this comment.
Out of curiosity, why collator_id is dropped from CandidateDescriptorV2?
There was a problem hiding this comment.
It was not useful and getting rid of it made space for core_index and session_index
There was a problem hiding this comment.
Take a look at RFC103 for more details
tdimitrov
approved these changes
Oct 25, 2024
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
on top of paritytech#5423 This PR implements the plumbing work required for paritytech#5047 . I also added additional helper methods gated by feature "test" in primitives. TODO: - [x] PRDoc --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: GitHub Action <action@github.com>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
on top of paritytech#5423 This PR implements the plumbing work required for paritytech#5047 . I also added additional helper methods gated by feature "test" in primitives. TODO: - [x] PRDoc --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: GitHub Action <action@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #5423
This PR implements the plumbing work required for #5047 . I also added additional helper methods gated by feature "test" in primitives.
TODO: