Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve APIs for Tries in Runtime #5756

Draft
wants to merge 72 commits into
base: master
Choose a base branch
from

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Sep 18, 2024

This is a refactor and improvement from: #3881

  • sp_runtime::proving_trie now exposes a BasicProvingTrie for both base2 and base16.
  • APIs for base16 are more focused on single value proofs, also aligning their APIs with the base2 trie
  • A ProvingTrie trait is included which wraps both the base2 and base16 trie, and exposes all APIs needed for an end to end scenario.
    • This is important because when writing benchmarks, you need abstractions to be able to create and prove tries of different sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants