-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve APIs for Tries in Runtime #5756
Draft
shawntabrizi
wants to merge
72
commits into
master
Choose a base branch
from
shawntabrizi-binary-trie2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+730
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1cfb29f.
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
…abrizi/polkadot-sdk into shawntabrizi-proving-trie
shawntabrizi
commented
Sep 18, 2024
…tech/polkadot-sdk into shawntabrizi-binary-trie2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor and improvement from: #3881
sp_runtime::proving_trie
now exposes aBasicProvingTrie
for bothbase2
andbase16
.base16
are more focused on single value proofs, also aligning their APIs with thebase2
trieProvingTrie
trait is included which wraps both thebase2
andbase16
trie, and exposes all APIs needed for an end to end scenario.