chore: export NodeHealthProxyLayer #5768
Conversation
yjhmelody
force-pushed
the
chore-NodeHealthProxyLayer
branch
from
80ef594
to
46e5144
Compare
| @@ -43,7 +42,7 @@ pub use jsonrpsee::{ | |||
| core::id_providers::{RandomIntegerIdProvider, RandomStringIdProvider}, | |||
| server::{middleware::rpc::RpcServiceBuilder, BatchRequestConfig}, | |||
| }; | |||
| pub use middleware::{Metrics, MiddlewareLayer, RpcMetrics}; | |||
| pub use middleware::{Metrics, MiddlewareLayer, NodeHealthProxyLayer, RpcMetrics}; | |||
There was a problem hiding this comment.
why is it useful to export the middleware implementation?
it's not possible to opt in/out from it anyway?
There was a problem hiding this comment.
I need to reimpl these rpc-servers and wanna add more layer.
Current, start_server could not add more layers for http.
So need to define the another.
There was a problem hiding this comment.
I don't follow, you want to write your own start server or an API to inject your own http middleware?
Anyway, doesn't hurt to re-export it from my-side
There was a problem hiding this comment.
It would be better to write an issue which what functionality you want.
We could expose APIs for folks to inject their own middleware both http and rpc... but it's a little tricky to get the traits bounds satisfied properly.
|
bot fmt |
|
@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7410937 was started for your command Comment |
|
@bkchr Command |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3962ec0
No description provided.