-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates: add genesis config presets for minimal/solochain #5868
templates: add genesis config presets for minimal/solochain #5868
Conversation
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
This reverts commit 2175419.
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Regarding #4739 (comment) Do we really need these functions? They look like some generic wrappers around |
@michalkucharczyk this is (partially) addressed here: #5705 and almost done here: #5804 |
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
f8807d1
Description
Closes #5790. Useful for starting nodes based on minimal/solochain when doing development or for testing omni node with less happy code paths. It is reusing the presets defined for the nodes chain specs.
Integration
Specifically useful for development/testing if generating chain-specs for
minimal
orsolochain
runtimes fromtemplates
directories.Review Notes
Added
genesis_config_presets
modules for both minimal/solochain. I reused the presets defined in each nodechain_spec
module correspondingly.PRDOC
Not sure who uses templates, maybe node devs and runtime devs at start of their learning journey, but happy to get some guidance on how to write the prdoc if needed.
Thinking out loud
I saw concerns around sharing functionality for such genesis config presets between the template chains. I think there might be a case for doing that, on the lines of this comment: #4739 (comment). I would add that
parachains-common::genesis_config_heleper
contains a few methods from those mentioned, but I am unsure if using it as a dependency for templates is correct. Feels like the comment suggests there should be acommons
crate concerning justtemplates
, which I agree with to some degree, if we assumecumulus
needs might be driven in certain directions that are not relevant totemplates
and vice versa. However I am not so certain about this, so would welcome some thoughts, since I am seeingparachains-common
being used already in a few runtime implementations: https://crates.io/crates/parachains-common/reverse_dependencies?page=3, so might be a good candidate already for thecommon
logic.