-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowbridge V2 docs #5902
Snowbridge V2 docs #5902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great write-up capturing everything we discussed!
bridges/snowbridge/docs/v2.md
Outdated
2. Dry-run $x_1$ on AH to receive xcm $x_2$ and cost $b$ in DOT | ||
3. Dry-run $x_2$ on BH to receive command $m$ and cost $c$ in DOT | ||
4. Dry-run $m$ on Ethereum to receive cost $d$ in ETH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you previously stated $P^{'}$
and $E^{'}$
were the native currency of Polkadot and Ethereum respectively, should those be used here? Or should we just use DOT and ETH throughout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mathematical notation was useful for distilling the essence of the algorithm. However I've made it more clear in 495ab69 that DOT and ETH are alternative names.
bridges/snowbridge/docs/v2.md
Outdated
- Given source parachain $S$, with native token $S^{'}$ and the initial xcm $x_0$ to be executed on $S$. | ||
- The native currency $P^{'}$ of the Polkadot relay chain, and $E^{'}$ of Ethereum. | ||
- Suppose that the user agent chooses relayer reward $r$ in $E^{'}$. | ||
- Suppose that the exchange rates $K_{P^{'}/S^{'}}$ and $K_{E^{'}/S^{'}}$. The user agent chooses a multiplier to $\beta$ to cover volatility in these rates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rates are obtained off-chain and the total fee might be too low if the rates were wrong and beta not enough to cover the difference, right?
I might add a little note here to highlight the importance of getting the correct exchange rates and the consequence of not having them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great writeup 😄
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/snowbridge-september-update/10389/1 |
90ff47d
* master: (28 commits) `substrate-node`: removed excessive polkadot-sdk features (#5925) Rename QueueEvent::StartWork (#6015) [ci] Remove quick-benchmarks-omni from GitLab (#6014) Set larger timeout for cmd.yml (#6006) Fix `0003-beefy-and-mmr` test (#6003) Remove redundant XCMs from dry run's forwarded xcms (#5913) Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967) Bump strum from 0.26.2 to 0.26.3 (#5943) Add PVF execution priority (#4837) Snowbridge V2 docs (#5902) Fix u256 conversion in BABE (#5994) [ci] Move test-linux-stable-no-try-runtime to GHA (#5979) Bump PoV request timeout (#5924) [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963) [ci] Remove short-benchmarks from Gitlab (#5988) Disable flaky tests reported in 5972/5973/5974 (#5976) Bump some dependencies (#5886) bump zombienet version and set request for k8s (#5968) [omni-bencher] Make all runtimes work (#5872) Omni-Node renamings (#5915) ...
Here are MD docs for V2 @acatangiu @franciscoaguirre . Let me know what you think.