Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable approval-voting-parallel by default on kusama #6218

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Enable approval-voting-parallel by default on kusama #6218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be028d6
Enable approval-voting-parallel by default on kusama
alexggh Oct 24, 2024
85408f4
Add prdoc
alexggh Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions polkadot/node/service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,13 +759,12 @@ pub fn new_full<
Some(backoff)
};

// Running approval voting in parallel is enabled by default on all networks except Polkadot and
// Kusama, unless explicitly enabled by the commandline option.
// Running approval voting in parallel is enabled by default on all networks except Polkadot
// unless explicitly enabled by the commandline option.
// This is meant to be temporary until we have enough confidence in the new system to enable it
// by default on all networks.
let enable_approval_voting_parallel = (!config.chain_spec.is_kusama() &&
!config.chain_spec.is_polkadot()) ||
enable_approval_voting_parallel;
let enable_approval_voting_parallel =
!config.chain_spec.is_polkadot() || enable_approval_voting_parallel;

let disable_grandpa = config.disable_grandpa;
let name = config.network.node_name.clone();
Expand Down
9 changes: 9 additions & 0 deletions prdoc/pr_6218.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
title: Enable approval-voting-parallel by default on kusama

doc:
- audience: Node Dev
description: |
Enable approval-voting-parallel by default on kusama
crates:
- name: polkadot-service
bump: patch
Loading