Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DHT content providers API from sc-network #6711

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Expose DHT content providers API from sc-network #6711

wants to merge 7 commits into from
+371 −50

Conversation

dmitry-markin
Copy link
Contributor

Expose the Kademlia content providers API for the use by sc-network client code:

  1. Extend the NetworkDHTProvider trait with functions to start/stop providing content and query the DHT for the list of content providers for a given key.
  2. Extend the DhtEvent enum with events reporting the found providers or query failures.
  3. Implement the above for libp2p & litep2p network backends.

@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Nov 29, 2024
@dmitry-markin dmitry-markin self-assigned this Nov 29, 2024
@dmitry-markin
Copy link
Contributor Author

/cmd prdoc --audience node_dev

@dmitry-markin
Copy link
Contributor Author

It looks like the CI always gets stuck after a /cmd prdoc command. Another PR where I had to manually kick the CI after /cmd prdoc is #6703.

CC @alvicsam

lexnv
lexnv approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dmitry-markin and others added 2 commits December 4, 2024 13:49
@dmitry-markin @lexnv
Apply suggestions from code review
fa5c592 
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
@dmitry-markin
Refactor pending kad queries into single pending_queries
d4cf32a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@bkchr bkchr bkchr approved these changes

@alexggh alexggh Awaiting requested review from alexggh

Assignees

@dmitry-markin dmitry-markin

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
Networking
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-markin @bkchr @lexnv @actions-user