Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] network/libp2p: Investigate requests that don't timeout #7154

Closed
wants to merge 2 commits into from

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Jan 14, 2025

This PR investigates if pending_requests contains any hanging requests.

cc @paritytech/networking

@lexnv lexnv self-assigned this Jan 14, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12786855727
Failed job name: test-linux-stable

lexnv added 2 commits January 15, 2025 18:20
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv force-pushed the lexnv/net-invest-timeout branch from 0b9fd7e to a078d2d Compare January 15, 2025 16:21
@lexnv lexnv requested review from acatangiu, sorpaas, cheme, a team and koute as code owners January 15, 2025 16:21
@lexnv lexnv changed the base branch from master to stable2412 January 15, 2025 16:21
@lexnv
Copy link
Contributor Author

lexnv commented Jan 15, 2025

Forced pushed because stable2412 runs libp2p "0.52.4", while origin master runs "0.54.1".
There has been a lot of code refactoring, and we want to debug as close as possible to the version our validators are running.

libp2p 0.54.1 also contains a few DHT regressions / timeouts

@lexnv lexnv removed request for a team, koute, cheme, sorpaas and acatangiu January 15, 2025 17:11
@lexnv
Copy link
Contributor Author

lexnv commented Jan 23, 2025

Solved in: #7222

@lexnv lexnv closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant