Fixes #219 #7407
Merged
Fixes #219 #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Lau <x@acg.box>
aurexav
force-pushed
the
dispatch-as-checked
branch
from
c6b8a3b to
98ccdc1
Compare
gui1117
approved these changes
Feb 1, 2025
substrate/frame/utility/src/lib.rs
Outdated
| @@ -454,6 +454,36 @@ pub mod pallet { | |||
| let res = call.dispatch_bypass_filter(frame_system::RawOrigin::Root.into()); | |||
| res.map(|_| ()).map_err(|e| e.error) | |||
| } | |||
|
|
|||
| /// Dispatches a function call with a provided origin. | |||
| /// Almost the same as [`Pallet::dispatch_as`] but check the result of the call. | |||
There was a problem hiding this comment.
Maybe we can be more explicit and say it will return an error if the call returns an error.
I find the verb "check" a bit vague here.
bkchr
reviewed
Feb 10, 2025
substrate/frame/utility/src/lib.rs
Outdated
| dispatch_info.class, | ||
| ) | ||
| })] | ||
| pub fn dispatch_as_checked( |
There was a problem hiding this comment.
Suggested change
| pub fn dispatch_as_checked( | |
| pub fn dispatch_as_fallible( |
Maybe that sounds better?
Co-authored-by: Bastian Köcher <git@kchr.de>
|
@aurexav will you finish this? |
…adot-sdk into dispatch-as-checked
Done. Quite busy these days and forgot about this. |
|
It will also need a PRdoc |
bkchr
approved these changes
Feb 17, 2025
Updated the desc. Does |
|
/cmd prdoc --audience runtime_dev,runtime_user --bump minor |
|
Command "" has started 🚀 See logs here |
|
Command "" has finished ✅ See logs here |
|
it doesn't seem to work, the patch from the job is empty. |
|
/cmd prdoc --audience runtime_dev --bump minor |
|
/cmd fmt |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
paritytech:master
with commit Feb 18, 2025
1ac2e96
223 of 232 checks passed
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
Add a new extrinsic `dispatch_as_fallible`. It's almost the same as [`Pallet::dispatch_as`] but forwards any error of the inner call. Closes paritytech#219. And add more unit tests to cover `dispatch_as` and `dispatch_as_fallible`. --- Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y --------- Signed-off-by: Xavier Lau <x@acg.box> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new extrinsic
dispatch_as_fallible.It's almost the same as [
Pallet::dispatch_as] but forwards any error of the inner call.Closes #219.
And add more unit tests to cover
dispatch_asanddispatch_as_fallible.Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y