pallet-assets: make touch other permissionless #7456
+34
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udience runtime_user --bump minor'
gui1117
commented
Feb 5, 2025
|
Fixes: #6648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7450
Pallet assets don't have the assumption that Admin and Freezer are trusted by the chain, so I don't see any security concern from this change.
The only difference I see is that people can create more account with 0 balance for a given asset, whereas in the past only privileged role could do it (privileged from the point of view of the asset, not the chain).
That said maybe this is not the actual fix we want, maybe it would be better to have accounts being able to increase their
MaxConsumersvalue by adding some deposit.