Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable approval-voting-parallel on polkadot #7504

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Feb 6, 2025

approval-voting-parallel has been running on all network types except polkadot since release 1.17.0, so it has around 2 months of baking and running without any reported issues, so let's enable it on polkadot as well.

After running in polkadot for awhile the flag will be entirely removed.

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh changed the title enable approval-voting paralllel on polkadot enable approval-voting parallel on polkadot Feb 6, 2025
@alexggh alexggh changed the title enable approval-voting parallel on polkadot enable approval-voting-parallel on polkadot Feb 6, 2025
polkadot/cli/src/cli.rs Outdated Show resolved Hide resolved
@alexggh alexggh added T8-polkadot This PR/Issue is related to/affects the Polkadot network. A4-needs-backport Pull request must be backported to all maintained releases. labels Feb 6, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13183180321
Failed job name: fmt

Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

polkadot/cli/src/cli.rs Outdated Show resolved Hide resolved
@alexggh alexggh enabled auto-merge February 7, 2025 08:34
@alexggh alexggh added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@alexggh alexggh added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit e5e0a6d Feb 7, 2025
207 of 211 checks passed
@alexggh alexggh deleted the enable_approval_voting_parallel_everywhere branch February 7, 2025 11:36
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7504-to-stable2407
git worktree add --checkout .worktree/backport-7504-to-stable2407 backport-7504-to-stable2407
cd .worktree/backport-7504-to-stable2407
git reset --hard HEAD^
git cherry-pick -x e5e0a6d36ae61f410f2d61a04e23cc643714145b
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7504-to-stable2409
git worktree add --checkout .worktree/backport-7504-to-stable2409 backport-7504-to-stable2409
cd .worktree/backport-7504-to-stable2409
git reset --hard HEAD^
git cherry-pick -x e5e0a6d36ae61f410f2d61a04e23cc643714145b
git push --force-with-lease

github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
approval-voting-parallel has been running on all network types except
polkadot since release `1.17.0`, so it has around 2 months of baking and
running without any reported issues, so let's enable it on polkadot as
well.

After running in polkadot for awhile the flag will be entirely removed.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
(cherry picked from commit e5e0a6d)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2412:

EgorPopelyaev pushed a commit that referenced this pull request Feb 7, 2025
Backport #7504 into `stable2412` from alexggh.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants