[AHM] Make pallet types public #7579
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
/cmd prdoc --bump minor --audience runtime-dev |
|
Command "prdoc --bump minor --audience runtime-dev" has failed ❌! See logs here |
|
/cmd prdoc --bump minor --audience runtime_dev |
| <<T as Config<I>>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance; | ||
| type VotingOf<T, I = ()> = Voting< | ||
| pub type VotingOf<T, I = ()> = Voting< |
There was a problem hiding this comment.
we also have some problem here with clone impl because of MaxVotes
There was a problem hiding this comment.
Yea I remember, I tried it but it introduces a lot of code since we have to manually implement Clone, Debug, PartialEq and Eq. Not really worth it in this case i think we can keep the aliases.
| @@ -157,7 +157,28 @@ pub mod pallet { | |||
| /// Weight information for extrinsics in this pallet. | |||
| type WeightInfo: weights::WeightInfo; | |||
|
|
|||
| /// Provider for the block number. Normally this is the `frame_system` pallet. | |||
| /// Query the current block number. | |||
There was a problem hiding this comment.
nice. can you copy this doc for all block number provider config types?
There was a problem hiding this comment.
Coped it to proxy, recovery and vesting now. Would have to check for the other pallets since it maybe needs to be tweaked first.
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
1 similar comment
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Preparation for AHM and making stuff public. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
Preparation for AHM and making stuff public.