Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Westend miner to skip the election submission one era every week #819

Closed
gpestana opened this issue Apr 28, 2024 · 3 comments
Closed

Westend miner to skip the election submission one era every week #819

gpestana opened this issue Apr 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gpestana
Copy link
Contributor

In order to test the unsigned submission often in Westend, we could configure the Westend miner to skip the election submission during a full era every week (e.g. Monday pref so we are online if things go south).

cc @Ank4n

@gpestana gpestana added the enhancement New feature or request label Apr 28, 2024
@kianenigma
Copy link
Contributor

kianenigma commented Apr 28, 2024

Westend runtime is still configured to not have a signed phase every now and then, so this is achieved. Or am I missing something?

https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/westend/src/lib.rs#L446

@niklasad1
Copy link
Member

I think it would easier just to turn-off the staking-miner by devops than to implement such thing in the staking-miner.

It's quite annoying to implement and we would to pass a flag that's westend and check the date on every sign phase but not that hard.

@gpestana
Copy link
Contributor Author

Westend runtime is still configured to not have a signed phase every now and then, so this is achieved.

I had a chat with @Ank4n and misunderstood that we don't have it anymore due to the merkelized metadata (paritytech/polkadot-sdk#3646). But that doesn't really impact the calculation for when the signed phase is 0 since SignedPhase itself are constants.

Closing this.

@github-project-automation github-project-automation bot moved this from 📕 Backlog to ✅ Done in (Nominated) Proof of Stake Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants