westend: SignedPhase is a constant

[bkchr]

In preparation for the merkleized metadata, we need to ensure that constants are actually constant. If we want to test the unsigned phase we could for example just disable signed voter. Or we add some extra mechanism to the pallet to disable the signed phase from time to time.

[Ank4n]

All good. We will figure out another way to achieve this.

[kianenigma]

Given that we don't have a workaround in this PR yet,
and given that I think this value is actually kinda useless in the metadata,
and given that I like the testing property of this constant being such, ensuring our OCW code path is being regularly,

I suggest removing this from the metadata instead of this.

@niklasad1 if the staking-miner doesn't break, then we are good. I think it is literally the only application that might read this from the metadata.

[kianenigma]

We will figure out another way to achieve this.

If not resolved within the context of this PR, please make an issue about it. If a good workaround exists, it might be a good one for mentoring.

[kianenigma]

My guess about this not being used in the staking miner was correct, so I suggest removing it from the metadata instead, as per the last commit.

[niklasad1]

The staking miner is only using the signed_phase constant from the metadata and AFAIU this only removes unsigned_phase constant, correct?

This won't break the staking miner and I tested it right now as well.

[niklasad1]

@bkchr why did you remove the signed_phase? It was still present when I had a look at this PR IIRC but after this commit it broke the staking miner :)

I don't think it should be that hard to workaround though....

[bkchr]

Because the fix that @kianenigma had done was incorrect :D Westend overwrites the SignedPhase, so only making UnsignedPhase not a constant doesn't solves my problem. I had really understood it like staking miner doesn't require any of them, but this was my misunderstanding. Sorry!