Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for multi-block miner #955

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

feat: support for multi-block miner #955

wants to merge 58 commits into from

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Jan 9, 2025 •
edited
Loading

This PR adds support for the multi-block pallet which is added as new monitor command which is hidden behind the feature-flag experimental-multi-block to support the election that are planned to be deployed on westend-assethub soon, See paritytech/polkadot-sdk#6996 for further context.

Thus, the "old miner a.k.a single-block miner" isn't modified and should work as it did before.

Manual testing done:

Things to improve (possibly after merging):

  • Proper integration test against the parachain assethub-next i.e. "westmint", "statemint" and "statemine"
  • Make the NPoS algorithm configurable
  • Prometheus metrics
  • Double check hardcoding values (worth looking into whether we can utilize metadata v16 to improve that)
  • Check verification after pages submitted
  • Currently the code only checks that no better scores exist on chain and that the miner hasn't submitted yet.
    This is not sufficient because we must also make sure that all pages have been submitted if requested.
    AFAIU, otherwise the miner may be slashed

Extra notes for reviewer, lots of code is changed due to refactoring but the most important parts is:

  • commands/multi-block/monitor.rs: which contains the logic how the snapshot/signed phase are handled.

kianenigma
kianenigma reviewed Jan 23, 2025
View reviewed changes
@kianenigma kianenigma mentioned this pull request Jan 28, 2025
Merged
26 tasks
niklasad1
niklasad1 commented Jan 31, 2025
View reviewed changes
@niklasad1 niklasad1 assigned niklasad1 and unassigned kianenigma Feb 3, 2025
@niklasad1 niklasad1 changed the title WIP: feature-gated single block/multi block miner feat: support for multi-block miner Feb 14, 2025
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Feb 14, 2025
@kianenigma @gpestana
@Ank4n @gui1117 @re-gius @github-actions
[AHM] Multi-block staking election pallet (#7282)
a025562 
## Multi Block Election Pallet

This PR adds the first iteration of the multi-block staking pallet. 

From this point onwards, the staking and its election provider pallets
are being customized to work in AssetHub. While usage in solo-chains is
still possible, it is not longer the main focus of this pallet. For a
safer usage, please fork and user an older version of this pallet.

---

## Replaces

- [x] #6034 
- [x] #5272

## Related PRs: 

- [x] #7483
- [ ] #7357
- [ ] #7424
- [ ] paritytech/polkadot-staking-miner#955

This branch can be periodically merged into
#7358 ->
#6996

## TODOs: 

- [x] rebase to master 
- Benchmarking for staking critical path
  - [x] snapshot
  - [x] election result
- Benchmarking for EPMB critical path
  - [x] snapshot
  - [x] verification
  - [x] submission
  - [x] unsigned submission
  - [ ] election results fetching
- [ ] Fix deletion weights. Either of
  - [ ] Garbage collector + lazy removal of all paged storage items
  - [ ] Confirm that deletion is small PoV footprint.
- [ ] Move election prediction to be push based. @tdimitrov 
- [ ] integrity checks for bounds 
- [ ] Properly benchmark this as a part of CI -- for now I will remove
them as they are too slow
- [x] add try-state to all pallets
- [x] Staking to allow genesis dev accounts to be created internally
- [x] Decouple miner config so @niklasad1 can work on the miner
72841b7
- [x] duplicate snapshot page reported by @niklasad1 
- [ ] #6520 or equivalent
-- during snapshot, `VoterList` must be locked
- [ ] Move target snapshot to a separate block

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request Feb 19, 2025
@kianenigma @gpestana
@Ank4n @gui1117 @re-gius @github-actions @clangenb
[AHM] Multi-block staking election pallet (paritytech#7282)
5988794 
## Multi Block Election Pallet

This PR adds the first iteration of the multi-block staking pallet. 

From this point onwards, the staking and its election provider pallets
are being customized to work in AssetHub. While usage in solo-chains is
still possible, it is not longer the main focus of this pallet. For a
safer usage, please fork and user an older version of this pallet.

---

## Replaces

- [x] paritytech#6034 
- [x] paritytech#5272

## Related PRs: 

- [x] paritytech#7483
- [ ] paritytech#7357
- [ ] paritytech#7424
- [ ] paritytech/polkadot-staking-miner#955

This branch can be periodically merged into
paritytech#7358 ->
paritytech#6996

## TODOs: 

- [x] rebase to master 
- Benchmarking for staking critical path
  - [x] snapshot
  - [x] election result
- Benchmarking for EPMB critical path
  - [x] snapshot
  - [x] verification
  - [x] submission
  - [x] unsigned submission
  - [ ] election results fetching
- [ ] Fix deletion weights. Either of
  - [ ] Garbage collector + lazy removal of all paged storage items
  - [ ] Confirm that deletion is small PoV footprint.
- [ ] Move election prediction to be push based. @tdimitrov 
- [ ] integrity checks for bounds 
- [ ] Properly benchmark this as a part of CI -- for now I will remove
them as they are too slow
- [x] add try-state to all pallets
- [x] Staking to allow genesis dev accounts to be created internally
- [x] Decouple miner config so @niklasad1 can work on the miner
72841b7
- [x] duplicate snapshot page reported by @niklasad1 
- [ ] paritytech#6520 or equivalent
-- during snapshot, `VoterList` must be locked
- [ ] Move target snapshot to a separate block

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@niklasad1 niklasad1

Labels
None yet
Projects
Security Audit (PRs) - SRLabs
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @kianenigma @gpestana