Code review feedback - fix vote count

paritytech · Dec 1, 2022 · fa68ca6 · fa68ca6
1 parent 4e40c77
commit fa68ca6
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/runtime/parachains/src/disputes.rs b/runtime/parachains/src/disputes.rs
@@ -1041,8 +1041,8 @@ impl<T: Config> Pallet<T> {
 		}
 
 		// Reject disputes containing less votes than needed for confirmation.
-		if summary.state.validators_for.count_ones() + summary.state.validators_against.count_ones() <
-			supermajority_threshold(summary.state.validators_for.len())
+		if (summary.state.validators_for.clone() | &summary.state.validators_against).count_ones() <=
+			byzantine_threshold(summary.state.validators_for.len())
 		{
 			return StatementSetFilter::RemoveAll
 		}
@@ -1211,9 +1211,8 @@ impl<T: Config> Pallet<T> {
 
 		// Reject disputes containing less votes than needed for confirmation.
 		ensure!(
-			summary.state.validators_for.count_ones() +
-				summary.state.validators_against.count_ones() >=
-				supermajority_threshold(summary.state.validators_for.len()),
+			(summary.state.validators_for.clone() | &summary.state.validators_against).count_ones() >
+				byzantine_threshold(summary.state.validators_for.len()),
 			Error::<T>::UnconfirmedDispute,
 		);