Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Flaky test bitfield_checks #4003

Closed
bkchr opened this issue Oct 4, 2021 · 2 comments · Fixed by #4004
Closed

Flaky test bitfield_checks #4003

bkchr opened this issue Oct 4, 2021 · 2 comments · Fixed by #4004
Labels
I5-tests Tests need fixing, improving or augmenting.

Comments

@bkchr
Copy link
Member

bkchr commented Oct 4, 2021

failures:
---- inclusion::tests::bitfield_checks stdout ----
thread 'inclusion::tests::bitfield_checks' panicked at 'assertion failed: ParaInclusion::process_bitfields(expected_bits(), vec![signed.into()],\n                                 &core_lookup).is_err()', runtime/parachains/src/inclusion.rs:1416:17
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/std/src/panicking.rs:515:5
   1: core::panicking::panic_fmt
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/panicking.rs:50:5
   3: std::thread::local::LocalKey<T>::with
   4: core::ops::function::FnOnce::call_once
   5: core::ops::function::FnOnce::call_once
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
    inclusion::tests::bitfield_checks
@bkchr bkchr added the I5-tests Tests need fixing, improving or augmenting. label Oct 4, 2021
@bkchr
Copy link
Member Author

bkchr commented Oct 4, 2021

			// non-pending bit set.
			{
				let mut bare_bitfield = default_bitfield();
				*bare_bitfield.0.get_mut(0).unwrap() = true;
				let signed = block_on(sign_bitfield(
					&keystore,
					&validators[0],
					ValidatorIndex(0),
					bare_bitfield,
					&signing_context,
				));

				assert!(ParaInclusion::process_bitfields(
					expected_bits(),
					vec![signed.into()],
					&core_lookup,
				)
				.is_err());
			}

Shouldn't that have been removed in: 9e4ee69 ?

It is also weird that locally I can only reproduce this when building the test in release, in debug it works...

@bkchr
Copy link
Member Author

bkchr commented Oct 4, 2021

Okay, I found out while debug vs release returns different results..

@ghost ghost closed this as completed in #4004 Oct 4, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant