Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix unoccupied bitfields #4004

Merged
3 commits merged into from
Oct 4, 2021
Merged

Fix unoccupied bitfields #4004

3 commits merged into from
Oct 4, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 4, 2021

If there is an unoccupied bitfield set, we should just ignore it and not
keep it for the rest of the logic in process_bitfields.

Fixes: #4003

If there is an unoccupied bitfield set, we should just ignore it and not
keep it for the rest of the logic in `process_bitfields`.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Oct 4, 2021
@bkchr bkchr requested a review from rphmeier October 4, 2021 08:57
@rphmeier
Copy link
Contributor

rphmeier commented Oct 4, 2021

bot merge

@ghost
Copy link

ghost commented Oct 4, 2021

Waiting for commit status.

@ghost ghost merged commit 6cb31e5 into master Oct 4, 2021
@ghost ghost deleted the bkchr-fix-bitfields branch October 4, 2021 11:14
ordian added a commit that referenced this pull request Oct 4, 2021
* master:
  Add extrinsic ordering filtering (#3631)
  chore: ci list files that spellcheck finds (#3992)
  Use background tasks properly in candidate-validation (#4002)
  Fix unoccupied bitfields (#4004)
  Bump syn from 1.0.77 to 1.0.78 (#4006)
ordian added a commit that referenced this pull request Oct 5, 2021
* master: (138 commits)
  Allow an Offset to Lease Periods (#3980)
  Bump quote from 1.0.9 to 1.0.10 (#4013)
  Companion for #9834 (Transaction Priority) (#3901)
  chore: update `builder` image (#3884)
  Free disputed cores before processing bitfields (#4008)
  Make candidate validation timeouts configurable (#4001)
  Add extrinsic ordering filtering (#3631)
  chore: ci list files that spellcheck finds (#3992)
  Use background tasks properly in candidate-validation (#4002)
  Fix unoccupied bitfields (#4004)
  Bump syn from 1.0.77 to 1.0.78 (#4006)
  Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931)
  fix clock drift for assignments issued before the block (#3851)
  Remove unoccupied bit check (#3999)
  bump substrate (#4000)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test bitfield_checks
2 participants