Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

some tweaks to rococo-local #3996

Merged
2 commits merged into from
Oct 2, 2021
Merged

some tweaks to rococo-local #3996

2 commits merged into from
Oct 2, 2021

Conversation

ordian
Copy link
Member

@ordian ordian commented Oct 2, 2021

4 validators with 1 size backing group. This is useful for disputes and simnet testing.

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 2, 2021
@rphmeier
Copy link
Contributor

rphmeier commented Oct 2, 2021

bot merge

@ghost
Copy link

ghost commented Oct 2, 2021

Waiting for commit status.

@ghost ghost merged commit 62bc021 into master Oct 2, 2021
@ghost ghost deleted the ao-tweak-rococo-local-genesis branch October 2, 2021 13:40
ordian added a commit to Lldenaurois/polkadot that referenced this pull request Oct 2, 2021
@ordian
Merge branch 'master' into ladi-logging-disputes
dade923 
* master:
  preserve finalized block in active leaves (paritytech#3997)
  some tweaks to rococo-local (paritytech#3996)
  always broadcast tranche 0 assignments and add a delay before approval (paritytech#3904)
  Tidy up XCM errors in preparation for v2. (paritytech#3988)
  add disputes call to Rococo (paritytech#3993)
  Fix an off-by-one: revert rather than revert-to (paritytech#3991)
  add logs to relay chain selection (paritytech#3990)
  av-store: clean up StoreAvailableData message (paritytech#3984)
  add polkadot-simnet runner (paritytech#3985)
  Remove incorrect proof about Jemalloc (paritytech#3982)
  add new rococo chainspec (paritytech#3976)
  bump async-std's version to remove conflict for substrate (paritytech#3981)
  gossip-support: set last_session_index earlier (paritytech#3978)
bkchr
bkchr reviewed Oct 2, 2021
View reviewed changes
node/service/src/chain_spec.rs
vec![
get_authority_keys_from_seed("Alice"),
get_authority_keys_from_seed("Bob"),
get_authority_keys_from_seed("Charlie"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably break tons of stuff, like tutorials and what else. Everything assumes 2 authorities. Could you please revert this.

You could just copy the function and have a different chain spec for your testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch! Do you think we could reuse wococo-local for that as we currently disable bridges modules in rococo runtime, so it doesn't serve its original purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used a custom chain spec name (as you can use whatever you want), but as wococo isn't used currently it should be fine as well.

@ordian ordian mentioned this pull request Oct 3, 2021
Merged
ordian added a commit that referenced this pull request Oct 3, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
e0f8223 
* master: (72 commits)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  always broadcast tranche 0 assignments and add a delay before approval (#3904)
  Tidy up XCM errors in preparation for v2. (#3988)
  add disputes call to Rococo (#3993)
  Fix an off-by-one: revert rather than revert-to (#3991)
  add logs to relay chain selection (#3990)
  av-store: clean up StoreAvailableData message (#3984)
  add polkadot-simnet runner (#3985)
  Remove incorrect proof about Jemalloc (#3982)
  add new rococo chainspec (#3976)
  bump async-std's version to remove conflict for substrate (#3981)
  gossip-support: set last_session_index earlier (#3978)
  Companion for substrate PR#9890 (#3961)
  Bump version, tx_version and spec_version in prep for v0.9.11 (#3970)
  Fix master compilation (#3977)
  Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627)
  ...
ordian added a commit that referenced this pull request Oct 5, 2021
@ordian
Merge branch 'master' into andre/companion-9448
9e0e469 
* master: (138 commits)
  Allow an Offset to Lease Periods (#3980)
  Bump quote from 1.0.9 to 1.0.10 (#4013)
  Companion for #9834 (Transaction Priority) (#3901)
  chore: update `builder` image (#3884)
  Free disputed cores before processing bitfields (#4008)
  Make candidate validation timeouts configurable (#4001)
  Add extrinsic ordering filtering (#3631)
  chore: ci list files that spellcheck finds (#3992)
  Use background tasks properly in candidate-validation (#4002)
  Fix unoccupied bitfields (#4004)
  Bump syn from 1.0.77 to 1.0.78 (#4006)
  Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931)
  fix clock drift for assignments issued before the block (#3851)
  Remove unoccupied bit check (#3999)
  bump substrate (#4000)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ordian @rphmeier @bkchr