This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix clock drift for assignments issued before the block #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
Lldenaurois
force-pushed
the
rh-fix-clock-drift
branch
from
b1abe91
to
a4dd1f0
Compare
rphmeier
commented
Sep 27, 2021
| next_no_show: None, | ||
| maximum_broadcast: 3, | ||
| clock_drift: block_tick, | ||
| RequiredTranches::Exact { |
There was a problem hiding this comment.
Given the name of the test I suspect that this test is wrong if the result is not Pending
rphmeier
commented
Sep 27, 2021
rphmeier
commented
Sep 27, 2021
…o rh-fix-clock-drift
ordian
approved these changes
Oct 3, 2021
ordian
added a commit
that referenced
this pull request
Oct 5, 2021
* master: (138 commits) Allow an Offset to Lease Periods (#3980) Bump quote from 1.0.9 to 1.0.10 (#4013) Companion for #9834 (Transaction Priority) (#3901) chore: update `builder` image (#3884) Free disputed cores before processing bitfields (#4008) Make candidate validation timeouts configurable (#4001) Add extrinsic ordering filtering (#3631) chore: ci list files that spellcheck finds (#3992) Use background tasks properly in candidate-validation (#4002) Fix unoccupied bitfields (#4004) Bump syn from 1.0.77 to 1.0.78 (#4006) Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931) fix clock drift for assignments issued before the block (#3851) Remove unoccupied bit check (#3999) bump substrate (#4000) change genesis authority set for wococo-local, revert rococo-local (#3998) ignore irrelevant approvals in logs (#3859) avoid expect, on free availability core (#3994) preserve finalized block in active leaves (#3997) some tweaks to rococo-local (#3996) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our tests, we typically import a block with tick 10 and then import assignments recorded at tick 0 (as the test clock is at tick 0). This often leads to the nonsensical tranche-0 no-show wakeups at tick 20, when they should be at 30 (block-tick + no-show-delay = 10 + 20 = 30).
This breaks a bunch of tests, so those need to be fixed first.