Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add logs to relay chain selection #3990

Merged
3 commits merged into from
Oct 1, 2021
Merged

add logs to relay chain selection #3990

3 commits merged into from
Oct 1, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Oct 1, 2021

For debugability, adds relay chain selection logs.

@drahnr drahnr force-pushed the bernhard-relay-chain-sel-logs branch from 36003eb to d287793 Compare October 1, 2021 18:19
@drahnr drahnr self-assigned this Oct 1, 2021
@drahnr drahnr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 1, 2021
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add logs for best_chain and then it's good to go.

@drahnr
Copy link
Contributor Author

drahnr commented Oct 1, 2021

Please add logs for best_chain and then it's good to go.

It's already there I think: https://github.com/paritytech/polkadot/pull/3990/files#diff-cb277cc4cd542f9f6daab01f6c7894b5ec8131e1f226e10a5524a9fcb5e05780R303-R316

@rphmeier
Copy link
Contributor

rphmeier commented Oct 1, 2021

bot merge

@ghost
Copy link

ghost commented Oct 1, 2021

Waiting for commit status.

@ghost ghost merged commit 14de1c1 into master Oct 1, 2021
@ghost ghost deleted the bernhard-relay-chain-sel-logs branch October 1, 2021 19:46
ordian added a commit to Lldenaurois/polkadot that referenced this pull request Oct 2, 2021
* master:
  preserve finalized block in active leaves (paritytech#3997)
  some tweaks to rococo-local (paritytech#3996)
  always broadcast tranche 0 assignments and add a delay before approval (paritytech#3904)
  Tidy up XCM errors in preparation for v2. (paritytech#3988)
  add disputes call to Rococo (paritytech#3993)
  Fix an off-by-one: revert rather than revert-to (paritytech#3991)
  add logs to relay chain selection (paritytech#3990)
  av-store: clean up StoreAvailableData message (paritytech#3984)
  add polkadot-simnet runner (paritytech#3985)
  Remove incorrect proof about Jemalloc (paritytech#3982)
  add new rococo chainspec (paritytech#3976)
  bump async-std's version to remove conflict for substrate (paritytech#3981)
  gossip-support: set last_session_index earlier (paritytech#3978)
ordian added a commit that referenced this pull request Oct 3, 2021
* master: (72 commits)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  always broadcast tranche 0 assignments and add a delay before approval (#3904)
  Tidy up XCM errors in preparation for v2. (#3988)
  add disputes call to Rococo (#3993)
  Fix an off-by-one: revert rather than revert-to (#3991)
  add logs to relay chain selection (#3990)
  av-store: clean up StoreAvailableData message (#3984)
  add polkadot-simnet runner (#3985)
  Remove incorrect proof about Jemalloc (#3982)
  add new rococo chainspec (#3976)
  bump async-std's version to remove conflict for substrate (#3981)
  gossip-support: set last_session_index earlier (#3978)
  Companion for substrate PR#9890 (#3961)
  Bump version, tx_version and spec_version in prep for v0.9.11 (#3970)
  Fix master compilation (#3977)
  Make most XCM APIs accept an Into<MultiLocation> where MultiLocation is accepted (#3627)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants