Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add pre-checking into the configuration runtime module #4010

Closed
Tracked by #3211
pepyakin opened this issue Oct 4, 2021 · 0 comments · Fixed by #4420
Closed
Tracked by #3211

Add pre-checking into the configuration runtime module #4010

pepyakin opened this issue Oct 4, 2021 · 0 comments · Fixed by #4420
Assignees
@pepyakin

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Oct 4, 2021

Into the configuration pallet we should add several new fields for #3211. Here is a rough list:

  • PVF pre-checking bypass. A boolean. If enabled then PVF is accepted immediately without pre-checking process.
  • PVF soaking period. The minimum number of blocks validation code should be stored in the storage before being usable. This may or may not be the same as validation_upgrade_delay, thus maybe renaming would do.
  • Minimum upgrade delay. If a parachain upgrades to new code which has already soaked, we should still introduce a minimum delay specified by this field.
  • PVF voting TTL. The number of session changes a PVF pre-checking voting can observe. If it observed this number of session changes it is treated as unviable and the PVF gets rejected.

This change requires migration. Refer to #3575 as an example
@pepyakin pepyakin mentioned this issue Oct 4, 2021
Closed
24 tasks
@slumber slumber mentioned this issue Oct 29, 2021
Closed
@pepyakin pepyakin assigned pepyakin and unassigned slumber Nov 30, 2021
pepyakin added a commit that referenced this issue Nov 30, 2021
@pepyakin
pvf-precheck: update configuration module
90fa10f 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.

There are several TODOs:

- [ ] Fill in the PR number for the reference in migration code
- [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems
  that u32 will be close enough, but maybe we still want to add weight
  for boolean parameters
- [ ] Test the upgrade.
@pepyakin pepyakin mentioned this issue Nov 30, 2021
Merged
3 tasks
pepyakin added a commit that referenced this issue Nov 30, 2021
@pepyakin
pvf-precheck: update configuration module
1dae102 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.

There are several TODOs:

- [ ] Fill in the PR number for the reference in migration code
- [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems
  that u32 will be close enough, but maybe we still want to add weight
  for boolean parameters
- [ ] Test the upgrade.
pepyakin added a commit that referenced this issue Nov 30, 2021
@pepyakin
pvf-precheck: update configuration module
2be5ed0 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.

There are several TODOs:

- [ ] Fill in the PR number for the reference in migration code
- [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems
  that u32 will be close enough, but maybe we still want to add weight
  for boolean parameters
- [ ] Test the upgrade.
pepyakin added a commit that referenced this issue Dec 1, 2021
@pepyakin
pvf-precheck: update configuration module
d0f2e99 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.

There are several TODOs:

- [ ] Fill in the PR number for the reference in migration code
- [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems
  that u32 will be close enough, but maybe we still want to add weight
  for boolean parameters
- [ ] Test the upgrade.
@pepyakin pepyakin linked a pull request Dec 1, 2021 that will close this issue
pvf-precheck: update configuration module #4420
Merged
3 tasks
pepyakin added a commit that referenced this issue Dec 1, 2021
@pepyakin
pvf-precheck: update configuration module
1629aaa 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 3, 2021
@pepyakin
pvf-precheck: update configuration module
c795d61 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 3, 2021
@pepyakin
pvf-precheck: update configuration module
5ec1b45 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 3, 2021
@pepyakin
pvf-precheck: update configuration module
8d5a539 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 3, 2021
@pepyakin
pvf-precheck: update configuration module
ddd68c4 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 7, 2021
@pepyakin
pvf-precheck: update configuration module
cf3fb54 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
pepyakin added a commit that referenced this issue Dec 8, 2021
@pepyakin
pvf-precheck: update configuration module
ed68222 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
paritytech-processbot bot pushed a commit that referenced this issue Dec 8, 2021
@pepyakin
pvf-precheck: update configuration module (#4420)
10f3c85 
This PR is a part of #3211.

This PR adds three new fields into the `HostConfiguration` structure.
The fields are going to be used in PRs down the stack.

This change requires migration, so this PR performs runtime storage
migration for configuration module from version 1 to version 2.

This PR closes #4010 and subsumes #4177.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pepyakin pepyakin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pepyakin @slumber