Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add new info command to the staking-miner #5560

Closed
chevdor opened this issue May 19, 2022 · 0 comments · Fixed by #5577
Closed

Add new info command to the staking-miner #5560

chevdor opened this issue May 19, 2022 · 0 comments · Fixed by #5577
Assignees
Labels
J0-enhancement An additional feature request.

Comments

@chevdor
Copy link
Contributor

chevdor commented May 19, 2022

Add a new staking miner command called info that returns the runtime version expected by this version of the miner.

Sample call:

staking-miner info

output:

{
     "runtime": 9220
}

cc @kianenigma @PierreBesson @niklasad1

@chevdor chevdor added the J0-enhancement An additional feature request. label May 19, 2022
@chevdor chevdor changed the title Add new info command to the staking-miner Add new info command to the staking-miner May 19, 2022
chevdor added a commit that referenced this issue May 20, 2022
@chevdor chevdor self-assigned this May 20, 2022
chevdor added a commit that referenced this issue Jun 5, 2022
chevdor added a commit that referenced this issue Jun 21, 2022
chevdor added a commit that referenced this issue Jun 25, 2022
* Refactoring opts out

* Implement info command

fix #5560

* remove useless change

* Remove unnecessary brackets

* Fix and add tests

* Promote the uri flag to global

* Ignore lint identity ops

* Reverse adding #[allow(identity_op)]

* Add cli test for the info command

* Add licende headers and fix some grumbles

* Add retrieval of the linked version and make the json output optional

* Fix tests

* Keep it generic and renamed builtin into linked

* Rebase master

* Add runtimes compatibility information

* Silence erroneous warning about unsafe

* Fix spellcheck

* Update utils/staking-miner/src/runtime_versions.rs

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
al3mart pushed a commit that referenced this issue Jul 14, 2022
* Refactoring opts out

* Implement info command

fix #5560

* remove useless change

* Remove unnecessary brackets

* Fix and add tests

* Promote the uri flag to global

* Ignore lint identity ops

* Reverse adding #[allow(identity_op)]

* Add cli test for the info command

* Add licende headers and fix some grumbles

* Add retrieval of the linked version and make the json output optional

* Fix tests

* Keep it generic and renamed builtin into linked

* Rebase master

* Add runtimes compatibility information

* Silence erroneous warning about unsafe

* Fix spellcheck

* Update utils/staking-miner/src/runtime_versions.rs

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant