start working on building the real overseer #1795

coriolinus · 2020-10-08T15:07:14Z

No description provided.

Unfortunately, this fails to compile right now due to an upstream failure to compile which is probably brought on by a recent upgrade to rustc v1.47.

node/service/src/lib.rs

node/network/collator-protocol/src/lib.rs

ordian · 2020-10-12T17:55:53Z

I think impl HeaderBackend for Arc<Client> is indeed missing. We could work around that by accepting Arc<RuntimeClient> like here (and in many other places) and/or implement that directly in substrate if possible.

It's not straightforwardly obvious that this is the best way to handle the case when there is no authority discovery service, but it seems to be the best option available at the moment.

node/service/src/lib.rs

node/core/av-store/src/lib.rs

…n Block

for debugging purposes, added this to node/subsystem-util/src/lib.rs:472-476: ```rust Some(registry) => Self::try_register(registry).map_err(|err| { eprintln!("PrometheusError calling {}::register: {:?}", std::any::type_name::<Self>(), err); err }), ``` That pointed out where the registration was failing, which led to this fix. The test still doesn't pass, but it now fails in a new and different way!

…er handlers

detailed logging determined that using the `Box::new` style of future generation, the `self.run` method was never being called, leading to dropped receivers / closed senders for those subsystems, causing the overseer to shut down immediately. This is not the final fix needed to get things working properly, but it's a good start.

rphmeier

Looks fine to me

coriolinus · 2020-10-27T09:53:07Z

Note: polkadod_proposer_block_constructed_count (grafana) has not reported any values since this branch was put onto that node. My expectation was that it would continue to produce blocks, but empty ones.

coriolinus · 2020-10-27T10:10:38Z

Meanwhile, looking at the logs (kibana), it looks like the node is up and running, but it's a bit hard to read because it looks like it's hard-emitting terminal color codes which Kibana isn't stripping.

bkchr · 2020-10-27T14:46:42Z

cli/src/browser.rs

+#[cfg(feature = "full-node")]
 use std::str::FromStr;


Suggested change

#[cfg(feature = "full-node")]

use std::str::FromStr;

This makes no sense... The browser node will not have the full-node feature activated.

This comes from f3fd10f; @montekki showed that it reduced warnings when building the browser target.

bkchr · 2020-10-27T14:48:08Z

cli/src/cli.rs

+
+	/// Set when this node is a collator.
+	///
+	/// When enabled, enables authority discovery.
+	#[structopt(long = "collator")]
+	pub is_collator: bool,


Suggested change

/// Set when this node is a collator.

///

/// When enabled, enables authority discovery.

#[structopt(long = "collator")]

pub is_collator: bool,

We don't need a cli flag for this. How should this even work? What would do the collating?

bkchr · 2020-10-27T14:48:40Z

node/core/av-store/Cargo.toml

@@ -19,6 +19,8 @@ polkadot-node-subsystem-util = { path = "../../subsystem-util" }
 polkadot-overseer = { path = "../../overseer" }
 polkadot-primitives = { path = "../../../primitives" }

+sc-service = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }


Suggested change

sc-service = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }

sc-service = { git = "https://github.com/paritytech/substrate", branch = "master" }

That comes from a4642e1 which fixes this CI failure.

bkchr · 2020-10-27T14:49:25Z

node/core/av-store/src/lib.rs

+			.map(|r| if let Err(e) = r {
+			log::error!(target: "availabilitystore", "Subsystem exited with an error {:?}", e);
+		}).boxed();


Weird formatting.

bkchr · 2020-10-27T14:54:53Z

node/service/src/lib.rs

@@ -740,30 +851,35 @@ pub fn build_light(config: Configuration) -> Result<(TaskManager, RpcHandlers),
 pub fn build_full(
 	config: Configuration,
 	authority_discovery_disabled: bool,
+	is_collator: bool,


Please make this an enum, as I have described it:

enum IsCollator { Yes, No, }

bkchr · 2020-10-27T14:56:07Z

node/service/src/lib.rs

+			let forward = forward.fuse();
+			let overseer_fut = overseer.run().fuse();
+
+			pin_mut!(overseer_fut);
+			pin_mut!(forward);


Suggested change

let forward = forward.fuse();

let overseer_fut = overseer.run().fuse();

pin_mut!(overseer_fut);

pin_mut!(forward);

let mut forward = forward.fuse();

let mut overseer_fut = overseer.run().fuse();

Should do the same?

Nope:

error[E0277]: `from_generator::GenFuture<[static generator@forward_events::{closure#0} for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9, 't10> {ResumeTy, Arc<sc_service::client::Client<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, LocalCallExecutor<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, NativeExecutor<Executor>>, sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>, RuntimeApi>>, OverseerHandler, sp_utils::mpsc::inner::TracingUnboundedReceiver<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, sp_utils::mpsc::inner::TracingUnboundedReceiver<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, Next<'r, sp_utils::mpsc::inner::TracingUnboundedReceiver<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, Next<'s, sp_utils::mpsc::inner::TracingUnboundedReceiver<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, [closure@forward_events::{closure#0}::{closure#0}], futures::future::PollFn<[closure@forward_events::{closure#0}::{closure#0}]>, (), forward_events::{closure#0}::__PrivResult<std::option::Option<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, std::option::Option<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, std::option::Option<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, &'t8 mut OverseerHandler, BlockInfo, impl futures::Future, std::option::Option<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, impl futures::Future}]>` cannot be unpinned --> node/service/src/lib.rs:591:5 | 591 | select! { | _________________^ 592 | | _ = forward => break, 593 | | _ = overseer_fut => break, 594 | | complete => break, 595 | | } | |_________________^ within `futures_util::future::future::fuse::_::__Fuse<'_, impl futures::Future>`, the trait `Unpin` is not implemented for `from_generator::GenFuture<[static generator@forward_events::{closure#0} for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9, 't10> {ResumeTy, Arc<sc_service::client::Client<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, LocalCallExecutor<sc_client_db::Backend<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, NativeExecutor<Executor>>, sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>, RuntimeApi>>, OverseerHandler, sp_utils::mpsc::inner::TracingUnboundedReceiver<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, sp_utils::mpsc::inner::TracingUnboundedReceiver<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, Next<'r, sp_utils::mpsc::inner::TracingUnboundedReceiver<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, Next<'s, sp_utils::mpsc::inner::TracingUnboundedReceiver<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, [closure@forward_events::{closure#0}::{closure#0}], futures::future::PollFn<[closure@forward_events::{closure#0}::{closure#0}]>, (), forward_events::{closure#0}::__PrivResult<std::option::Option<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, std::option::Option<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>>, std::option::Option<FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, FinalityNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, &'t8 mut OverseerHandler, BlockInfo, impl futures::Future, std::option::Option<BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>>, BlockImportNotification<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic>>, impl futures::Future}]>` | ::: /home/coriolinus/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/futures-util-0.3.5/src/async_await/mod.rs:43:24 | 43 | pub fn assert_unpin<T: Unpin>(_: &T) {} | ----- required by this bound in `futures_util::async_await::assert_unpin` | = note: required because it appears within the type `impl futures::Future` = note: required because it appears within the type `impl futures::Future` = note: required because it appears within the type `std::option::Option<impl futures::Future>` = note: required because it appears within the type `futures_util::future::future::fuse::_::__Fuse<'_, impl futures::Future>` = note: required because of the requirements on the impl of `Unpin` for `futures::future::Fuse<impl futures::Future>` = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) error[E0277]: `from_generator::GenFuture<[static generator@Overseer::<S>::run::{closure#0} for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9, 't10, 't11, 't12, 't13, 't14, 't15, 't16, 't17, 't18, 't19, 't20, 't21> {ResumeTy, Overseer<SpawnTaskHandle>, Vec<(H256, u32)>, ActiveLeavesUpdate, &'r mut Overseer<SpawnTaskHandle>, OverseerSignal, impl futures::Future, (), &'t0 mut futures::channel::mpsc::Receiver<polkadot_overseer::Event>, futures::channel::mpsc::Receiver<polkadot_overseer::Event>, Next<'t1, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>, &'t2 mut Next<'t3, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>, futures_util::async_await::poll::PollOnce<&'t4 mut Next<'t5, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>>, Poll<std::option::Option<polkadot_overseer::Event>>, polkadot_overseer::Event, polkadot_node_subsystem::messages::AllMessages, impl futures::Future, impl futures::Future, BlockInfo, impl futures::Future, impl futures::Future, &'t9 mut streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, Next<'t10, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>, &'t11 mut Next<'t12, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>, futures_util::async_await::poll::PollOnce<&'t13 mut Next<'t14, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>>, Poll<std::option::Option<(streamunordered::StreamYield<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, usize)>>, polkadot_overseer::ToOverseer, &'t15 mut FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't16)>>>, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't17)>>>, Next<'t18, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't19)>>>>, futures_util::async_await::poll::PollOnce<Next<'t20, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't21)>>>>>, Poll<std::option::Option<sc_service::Result<(), SubsystemError>>>, sc_service::Result<(), SubsystemError>, futures_util::async_await::pending::PendingOnce}]>` cannot be unpinned --> node/service/src/lib.rs:591:5 | 591 | select! { | _________________^ 592 | | _ = forward => break, 593 | | _ = overseer_fut => break, 594 | | complete => break, 595 | | } | |_________________^ within `futures_util::future::future::fuse::_::__Fuse<'_, impl futures::Future>`, the trait `Unpin` is not implemented for `from_generator::GenFuture<[static generator@Overseer::<S>::run::{closure#0} for<'r, 's, 't0, 't1, 't2, 't3, 't4, 't5, 't6, 't7, 't8, 't9, 't10, 't11, 't12, 't13, 't14, 't15, 't16, 't17, 't18, 't19, 't20, 't21> {ResumeTy, Overseer<SpawnTaskHandle>, Vec<(H256, u32)>, ActiveLeavesUpdate, &'r mut Overseer<SpawnTaskHandle>, OverseerSignal, impl futures::Future, (), &'t0 mut futures::channel::mpsc::Receiver<polkadot_overseer::Event>, futures::channel::mpsc::Receiver<polkadot_overseer::Event>, Next<'t1, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>, &'t2 mut Next<'t3, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>, futures_util::async_await::poll::PollOnce<&'t4 mut Next<'t5, futures::channel::mpsc::Receiver<polkadot_overseer::Event>>>, Poll<std::option::Option<polkadot_overseer::Event>>, polkadot_overseer::Event, polkadot_node_subsystem::messages::AllMessages, impl futures::Future, impl futures::Future, BlockInfo, impl futures::Future, impl futures::Future, &'t9 mut streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, Next<'t10, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>, &'t11 mut Next<'t12, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>, futures_util::async_await::poll::PollOnce<&'t13 mut Next<'t14, streamunordered::StreamUnordered<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>>>, Poll<std::option::Option<(streamunordered::StreamYield<futures::channel::mpsc::Receiver<polkadot_overseer::ToOverseer>>, usize)>>, polkadot_overseer::ToOverseer, &'t15 mut FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't16)>>>, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't17)>>>, Next<'t18, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't19)>>>>, futures_util::async_await::poll::PollOnce<Next<'t20, FuturesUnordered<Pin<Box<(dyn futures::Future<Output = sc_service::Result<(), SubsystemError>> + std::marker::Send + 't21)>>>>>, Poll<std::option::Option<sc_service::Result<(), SubsystemError>>>, sc_service::Result<(), SubsystemError>, futures_util::async_await::pending::PendingOnce}]>` | ::: /home/coriolinus/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/futures-util-0.3.5/src/async_await/mod.rs:43:24 | 43 | pub fn assert_unpin<T: Unpin>(_: &T) {} | ----- required by this bound in `futures_util::async_await::assert_unpin` | = note: required because it appears within the type `impl futures::Future` = note: required because it appears within the type `impl futures::Future` = note: required because it appears within the type `std::option::Option<impl futures::Future>` = note: required because it appears within the type `futures_util::future::future::fuse::_::__Fuse<'_, impl futures::Future>` = note: required because of the requirements on the impl of `Unpin` for `futures::future::Fuse<impl futures::Future>` = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

bkchr · 2020-10-27T14:56:50Z

node/service/src/lib.rs

+			pin_mut!(overseer_fut);
+			pin_mut!(forward);
+
+			loop {


Why do we loop here if we end anyway the first time any future resolves?

This loop can be removed

coriolinus · 2020-10-27T15:34:07Z

Block production: it appears that the burnin node is in fact producing blocks. We have not broken block production; we have broken metrics collection related to block production.

…nto prgn-real-overseer

coriolinus · 2020-10-28T10:21:24Z

bot merge

ghost · 2020-10-28T10:21:30Z

Waiting for commit status.

start working on building the real overseer

c4c6738

Unfortunately, this fails to compile right now due to an upstream failure to compile which is probably brought on by a recent upgrade to rustc v1.47.

coriolinus added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 8, 2020

fill in AllSubsystems internal constructors

a334432

ordian reviewed Oct 9, 2020

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

ordian reviewed Oct 9, 2020

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

ordian reviewed Oct 9, 2020

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

coriolinus added 4 commits October 9, 2020 13:25

Merge remote-tracking branch 'origin/master' into prgn-real-overseer

db98360

replace fn make_metrics with Metrics::attempt_to_register

b8c9463

update to account for #1740

e769207

remove Metrics::register, rename Metrics::attempt_to_register

98204d5

ordian reviewed Oct 9, 2020

View reviewed changes

node/network/collator-protocol/src/lib.rs Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into prgn-real-overseer

b847b85

coriolinus added 3 commits October 13, 2020 14:46

Merge remote-tracking branch 'origin/master' into prgn-real-overseer

40850ac

add 'static bounds to real_overseer type params

36eaa46

pass authority_discovery and network_service to real_overseer

7334016

It's not straightforwardly obvious that this is the best way to handle the case when there is no authority discovery service, but it seems to be the best option available at the moment.

bkchr reviewed Oct 13, 2020

View reviewed changes

node/service/src/lib.rs Outdated Show resolved Hide resolved

select a proper database configuration for the availability store db

5ea441e

ordian reviewed Oct 13, 2020

View reviewed changes

node/core/av-store/src/lib.rs Outdated Show resolved Hide resolved

use subdirectory for av-store database path

0720f5d

ordian reviewed Oct 15, 2020

View reviewed changes

node/core/av-store/src/lib.rs Outdated Show resolved Hide resolved

apply Basti's patch which avoids needing to parameterize everything o…

8185a55

…n Block

coriolinus force-pushed the prgn-real-overseer branch from e1cde5d to 8185a55 Compare October 15, 2020 13:02

ordian and others added 5 commits October 15, 2020 15:15

simplify path extraction

801063d

get all tests to compile

99a61f9

authorities must have authority discovery, but not necessarily overse…

ff63eb2

…er handlers

rphmeier approved these changes Oct 26, 2020

View reviewed changes

montekki approved these changes Oct 26, 2020

View reviewed changes

coriolinus added 4 commits October 27, 2020 12:05

Merge remote-tracking branch 'origin/master' into prgn-real-overseer

244e980

post-merge blues

cd97445

add is_collator flag

d1d4163

prevent occasional av-store test panic

283f426

coriolinus force-pushed the prgn-real-overseer branch from df7b1bb to 283f426 Compare October 27, 2020 12:23

coriolinus added 3 commits October 27, 2020 13:28

simplify fix; expand application

2ddc5ee

run authority_discovery in Role::Discover when collating

2bf2980

distinguish between proposer closed channel errors

ac0a90f

bkchr suggested changes Oct 27, 2020

View reviewed changes

coriolinus mentioned this pull request Oct 27, 2020

Merging 1795 breaks metric collection regarding block production #1861

Closed

coriolinus and others added 4 commits October 27, 2020 17:03

add IsCollator enum, remove is_collator CLI flag

566fd21

improve formatting

0f4a86e

remove nop loop

558844d

Fix some stuff

d16f502

bkchr approved these changes Oct 27, 2020

View reviewed changes

bkchr mentioned this pull request Oct 27, 2020

Adds test parachain adder collator #1864

Merged

coriolinus added 2 commits October 28, 2020 11:06

Merge remote-tracking branch 'origin/master' into prgn-real-overseer

51ce190

Merge branch 'prgn-real-overseer' of github.com:paritytech/polkadot i…

5791bb4

…nto prgn-real-overseer

ordian approved these changes Oct 28, 2020

View reviewed changes

ghost merged commit 798f781 into master Oct 28, 2020

ghost deleted the prgn-real-overseer branch October 28, 2020 10:26

pepyakin mentioned this pull request Oct 28, 2020

Update to the latest changes on master #1866

Merged

ordian mentioned this pull request Apr 1, 2021

Approval Voting improvements #2781

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

start working on building the real overseer #1795

start working on building the real overseer #1795

coriolinus commented Oct 8, 2020 •

edited

Loading

ordian commented Oct 12, 2020

rphmeier left a comment

coriolinus commented Oct 27, 2020

coriolinus commented Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

bkchr Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

bkchr Oct 27, 2020

coriolinus Oct 27, 2020

coriolinus commented Oct 27, 2020

coriolinus commented Oct 28, 2020

ghost commented Oct 28, 2020

	sc-service = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
	sc-service = { git = "https://github.com/paritytech/substrate", branch = "master" }

start working on building the real overseer #1795

start working on building the real overseer #1795

Conversation

coriolinus commented Oct 8, 2020 • edited Loading

ordian commented Oct 12, 2020

rphmeier left a comment

Choose a reason for hiding this comment

coriolinus commented Oct 27, 2020

coriolinus commented Oct 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coriolinus commented Oct 27, 2020

coriolinus commented Oct 28, 2020

ghost commented Oct 28, 2020

coriolinus commented Oct 8, 2020 •

edited

Loading