Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for substrate #7328 #1825

Merged
10 commits merged into from
Oct 21, 2020
Merged

Companion PR for substrate #7328 #1825

10 commits merged into from
Oct 21, 2020

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Oct 16, 2020

companion pr for paritytech/substrate#7328

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 16, 2020
@cecton cecton marked this pull request as draft October 16, 2020 16:03
@cecton cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 21, 2020
@cecton cecton marked this pull request as ready for review October 21, 2020 12:08
@cecton cecton requested a review from bkchr October 21, 2020 12:09
@cecton cecton mentioned this pull request Oct 21, 2020
Merged
bkchr
bkchr approved these changes Oct 21, 2020
View reviewed changes
node/service/src/lib.rs Outdated Show resolved Hide resolved
cecton and others added 3 commits October 21, 2020 16:06
@cecton @bkchr
Update node/service/src/lib.rs
bb77e29 
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
@cecton
WIP
fd47006
"Update Substrate"
88c5ce3
@ghost
Copy link

ghost commented Oct 21, 2020

Waiting for commit status.

@cecton
Copy link
Contributor Author

cecton commented Oct 21, 2020

bot merge force

@ghost
Copy link

ghost commented Oct 21, 2020

Trying merge.

@ghost
Copy link

ghost commented Oct 21, 2020

Merge failed: "2 of 2 required status checks have not succeeded: 1 expected and 1 pending."

@cecton
Copy link
Contributor Author

cecton commented Oct 21, 2020

bot merge

@ghost
Copy link

ghost commented Oct 21, 2020

Trying merge.

@ghost ghost merged commit be2771d into master Oct 21, 2020
@ghost ghost deleted the cecton-logging-singleton branch October 21, 2020 15:32
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cecton @bkchr