-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update to latest substrate-master and polkadot v0.3 #195
Conversation
* update substrate v0.3 to latest master * bump spec version * update to latest master: remove fees module * update runtime blobs * bump version to 0.3.16
* call on_finalise after triggering curated_grandpa change * make grandpa rounds shorter for faster finalization
* update to latest substrate master * bump version to 0.3.18 * update to latest substrate master * bump spec version * update runtime wasm blobs * remove current_offline_slash from chain spec
* update to substrate master: bump version to v0.3.19 libp2p network improvements * network: replace NodeIndex with PeerId * network: fix tests
* update to substrate master: bump version to 0.3.20 * runtime: add offchain worker trait * runtime: rebuild wasm blobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm. but would like @rphmeier to sign-off on it.
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "polkadot-service" | |||
version = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably use a different version for master branch (maybe 0.4?).
network/src/router.rs
Outdated
} | ||
|
||
/// Receiver for block data. | ||
pub struct BlockDataReceiver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used anymore.
Cargo.toml
Outdated
@@ -4,7 +4,7 @@ path = "src/main.rs" | |||
|
|||
[package] | |||
name = "polkadot" | |||
version = "0.3.0" | |||
version = "0.3.20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump to 0.4
?
@@ -254,15 +256,14 @@ construct_runtime!( | |||
Staking: staking, | |||
Democracy: democracy, | |||
Grandpa: grandpa::{Module, Call, Storage, Config<T>, Log(), Event<T>}, | |||
CuratedGrandpa: curated_grandpa::{Module, Call, Config<T>, Storage}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using curated_grandpa
, we should remove grandpa::SyncedAuthorities
from OnSessionChange
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one grumble, otherwise looks OK
This branch combines latest polkadot master, v0.3 and substrate master.