Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Session management for approval voting #1973

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Session management for approval voting #1973

merged 4 commits into from
Nov 24, 2020
+13 −4

Conversation

rphmeier
Copy link
Contributor

Skimmed over this before, but it's important.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 18, 2020
@rphmeier @coriolinus
Update roadmap/implementers-guide/src/node/approval/approval-voting.md
d81daf1 
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
@montekki
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Nov 20, 2020

Missing process info; check that the PR belongs to a project column.

Merge can be attempted if:

  • The PR has approval from two core-devs (or one if the PR is labelled insubstantial).
  • The PR has approval from a member of substrateteamleads.
  • The PR is attached to a project column and has approval from the project owner.

See https://github.com/paritytech/parity-processbot#faq

@rphmeier rphmeier merged commit ac46a9f into master Nov 24, 2020
@rphmeier rphmeier deleted the rh-approval-block-session branch November 24, 2020 21:44
ordian added a commit that referenced this pull request Nov 25, 2020
@ordian
Merge branch 'master' into ao-validator-discovery-previous-sessions
f1cc838 
* master:
  Some code cleanup in overseer (#2008)
  PoV Distribution optimization (#1990)
  Approval Distribution Subsystem (#1951)
  Session management for approval voting (#1973)
  Do not send messages twice in bitfield distribution (#2005)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rphmeier @montekki @bkchr @coriolinus