This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
XCM docs and tests #2948
Merged
XCM docs and tests #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
…to kiz-alex-test-xcm
…to kiz-alex-test-xcm
…to kiz-alex-test-xcm
apopiak
commented
Apr 28, 2021
…to kiz-alex-test-xcm
…to kiz-alex-test-xcm
…to kiz-alex-test-xcm
kianenigma
reviewed
May 9, 2021
| use sp_std::result; | ||
|
|
||
| /// Errors associated with [`MatchesFungibles`] operation. | ||
| pub enum Error { |
There was a problem hiding this comment.
This error type cannot (as-is) and should not accommodate all the variant errors that can happen in different implementations (elsewhere), if they can exist.
If ^^ is correct then we need type Error on MatchesFungibles, or a Other(..) variant for random stuff.
But for now it seemed like an overkill.
apopiak
commented
May 10, 2021
apopiak
commented
May 10, 2021
apopiak
commented
May 10, 2021
apopiak
commented
May 10, 2021
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
kianenigma
approved these changes
May 12, 2021
There was a problem hiding this comment.
I authored it partially as well, but still :p
This is becoming hard to maintain with upstream changes and I worry that it might become a stale PR. In that case, note that there was one small logical bug that was found here and make sure it is fixed elsewhere.
…to kiz-alex-test-xcm
shawntabrizi
approved these changes
Jun 3, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documentation and tests for XCM types and functions.
Mostly authored by @kianenigma 🙏
related to #2841