Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

State can be finished due to Share message. #3070

Merged
merged 4 commits into from
May 21, 2021
Merged

State can be finished due to Share message. #3070

merged 4 commits into from
May 21, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented May 21, 2021

Therefoe a task can still be running in that state. Removed panic and
changed state name to reflect possibility of Share messages.

@eskimor
State can be finished due to Share message.
76086d8 
Therefoe a task can still be running in that state. Removed panic and
changed state name to reflect possibility of `Share` message.
@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 21, 2021
ordian
ordian approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have it tested somehow, but not a blocker.

@bkchr bkchr added this to the v0.9.3 milestone May 21, 2021
@eskimor
Copy link
Member Author

eskimor commented May 21, 2021

bot merge

@ghost
Copy link

ghost commented May 21, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

@ordian
Copy link
Member

ordian commented May 21, 2021

#3071 fixes the CI

@ordian ordian merged commit 94b79d0 into master May 21, 2021
@ordian ordian deleted the rk-fix-invalid-state branch May 21, 2021 18:04
@ordian ordian mentioned this pull request May 21, 2021
Closed
ordian added a commit that referenced this pull request May 21, 2021
@ordian
Merge branch 'master' into ao-downgrade-uberverbose-logs
ec814c5 
* master:
  State can be finished due to `Share` message. (#3070)
  Add `parachain_desired_peer_count` metric (#3035)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@eskimor @ordian @bkchr