Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Additional test for shawntabrizi-check-bid (#3361) #3365

Closed
wants to merge 6 commits into from
Closed

Additional test for shawntabrizi-check-bid (#3361) #3365

wants to merge 6 commits into from

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Jun 25, 2021 •
edited
Loading

Add a test to assert the following

  • A bid that intersects with a won lease slot and a prior, non-won lease slot up for auction is rejected
  • A bid that does not intersected with a won lease slot but does intersect with a prior, non-won lease slot is accepted
  • A crowdloan that has already won its specified slot range will fail when entering a bid resulting from a poke

shawntabrizi and others added 5 commits June 24, 2021 14:04
@shawntabrizi
add already leased
716e160 
Co-Authored-By: parity-processbot <>
@shawntabrizi
add unit test
d4b3f90 
Co-Authored-By: parity-processbot <>
@shawntabrizi
add integration test and fix
be4014d 
Co-Authored-By: parity-processbot <>
@shawntabrizi
better doc
e33e1b7 
Co-Authored-By: parity-processbot <>
@emostov
Additional test for shawntabrizi-check-bid (#3361)
d0acf29
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 25, 2021
emostov
emostov commented Jun 25, 2021
View reviewed changes
runtime/common/src/integration_tests.rs
ParaId::from(2000),
2,
lease_period_index_start,
lease_period_index_start + 1,
Copy link
Contributor Author

@emostov emostov Jun 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a valid auction range that includes a prior slot to the one already won. The ones in your existing test that are most similiar use lease_period_index_start - 1, which would still error with "Invalid range for this auction" if the check you added was removed.

@Lldenaurois Lldenaurois mentioned this pull request Jun 25, 2021
Merged
Base automatically changed from shawntabrizi-check-bid to master June 25, 2021 10:56
@emostov
Copy link
Contributor Author

emostov commented Jun 25, 2021

Closing since the target branch/PR (#3361) is now merged

@emostov emostov closed this Jun 25, 2021
@emostov emostov deleted the zeke-add-test-shawntabrizi-check-bid branch September 26, 2021 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emostov @shawntabrizi