Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve test in bridge #3507

Merged
2 commits merged into from
Jul 22, 2021
Merged

Improve test in bridge #3507

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a72180
improve test
gui1117 Jul 21, 2021
f8d70b6
better doc
gui1117 Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bridges/modules/dispatch/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ mod tests {
#![allow(clippy::from_over_into)]

use super::*;
use frame_support::{parameter_types, weights::Weight};
use frame_support::{parameter_types, weights::Weight, dispatch::GetDispatchInfo};
use frame_system::{EventRecord, Phase};
use sp_core::H256;
use sp_runtime::{
Expand Down Expand Up @@ -599,9 +599,11 @@ mod tests {
fn should_fail_on_weight_mismatch() {
new_test_ext().execute_with(|| {
let id = [0; 4];
let mut message =
prepare_root_message(Call::System(<frame_system::Call<TestRuntime>>::remark(vec![1, 2, 3])));
let call = Call::System(<frame_system::Call<TestRuntime>>::remark(vec![1, 2, 3]));
let call_weight = call.get_dispatch_info().weight;
let mut message = prepare_root_message(call);
message.weight = 7;
assert!(call_weight != 7, "needed for test to be correct");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the comment here a little more?

Copy link
Contributor Author

@gui1117 gui1117 Jul 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test is testing for a weight mismatch, so we must not match the correct weight

I improved the message a bit


System::set_block_number(1);
let result = Dispatch::dispatch(SOURCE_CHAIN_ID, TARGET_CHAIN_ID, id, Ok(message), |_, _| unreachable!());
Expand All @@ -615,7 +617,7 @@ mod tests {
event: Event::Dispatch(call_dispatch::Event::<TestRuntime>::MessageWeightMismatch(
SOURCE_CHAIN_ID,
id,
1038000,
call_weight,
7,
)),
topics: vec![],
Expand Down