Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Parachains session_info.rs to FrameV2 #3521

Merged
8 commits merged into from
Jul 31, 2021
Merged

Parachains session_info.rs to FrameV2 #3521

8 commits merged into from
Jul 31, 2021

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 27, 2021 •
edited
Loading

relates: #2882

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the ParaSessionInfo pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the ParaSessionInfo pallet.

kusama and westend use ParasSessionInfo in construct_runtime!, so I migrated them to ParaSessionInfo

rococo uses SessionInfo in construct_runtime! so I migrated it to ParaSessionInfo

polkadot does not use ParaSessionInfo.

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 31, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Jul 31, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Jul 31, 2021

Merge aborted: Checks failed for 05e7075

KiChjang
KiChjang reviewed Jul 31, 2021
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
KiChjang
KiChjang reviewed Jul 31, 2021
View reviewed changes
runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Jul 31, 2021

Waiting for commit status.

@ghost ghost merged commit d0ac4ab into paritytech:master Jul 31, 2021
@ferrell-code ferrell-code deleted the fer-session_info branch July 31, 2021 19:00
ordian added a commit that referenced this pull request Aug 2, 2021
@ordian
Merge branch 'master' into ao-subsystem-do-not-use-ourviewchange
4093836 
* master:
  Companion PR for warp sync support. (#3382)
  Companion for #9373 (Refactor Benchmarks for Wasm Memory) (#3549)
  XCM simulator (#3538)
  Parachains scheduler.rs to FrameV2 (#3529)
  Parachains session_info.rs to FrameV2 (#3521)
  Companion for substrate #9319 (#3456)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrell-code @shawntabrizi @KiChjang