Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Parachains ump.rs to FrameV2 #3528

Merged
2 commits merged into from
Jul 27, 2021
Merged

Parachains ump.rs to FrameV2 #3528

2 commits merged into from
Jul 27, 2021

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 27, 2021 •
edited
Loading

relates: #2882

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Ump pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Ump pallet.

kusama and westend use ParasUmp in construct_runtime!, so I migrated them to Ump

rococo already uses Ump

polkadot does not use Ump.

@emostov emostov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 27, 2021
emostov
emostov approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@shawntabrizi shawntabrizi added the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Jul 27, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Jul 27, 2021

Waiting for commit status.

@ghost ghost merged commit aeeeeaf into paritytech:master Jul 27, 2021
@github-actions github-actions bot mentioned this pull request Aug 24, 2021
Closed
@ferrell-code ferrell-code deleted the fer-ump-framev2 branch November 1, 2021 04:18
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emostov emostov emostov approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrell-code @shawntabrizi @emostov