Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for 'Make choosing an executor an explicit part of service construction' (#9525) #3615

Merged
14 commits merged into from
Aug 18, 2021
Merged

Companion PR for 'Make choosing an executor an explicit part of service construction' (#9525) #3615

14 commits merged into from
Aug 18, 2021

Conversation

expenses
Copy link
Contributor

@expenses expenses added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 10, 2021
@expenses expenses mentioned this pull request Aug 10, 2021
Merged
@expenses expenses added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Aug 10, 2021
chevdor
chevdor approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@expenses
Copy link
Contributor Author

I merged in #3657 to get check-polkadot-companion-build to run properly.

@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 18, 2021

Trying merge.

@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Aug 18, 2021

Trying merge.

@ghost ghost merged commit 616667f into master Aug 18, 2021
@ghost ghost deleted the ashley-executor-service-stuff-comp branch August 18, 2021 13:26
@ferrell-code ferrell-code mentioned this pull request Aug 26, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@chevdor chevdor chevdor approved these changes

@gilescope gilescope gilescope approved these changes

@HCastano HCastano HCastano approved these changes

@cecton cecton Awaiting requested review from cecton

@andresilva andresilva Awaiting requested review from andresilva

@bkchr bkchr Awaiting requested review from bkchr

@svyatonik svyatonik Awaiting requested review from svyatonik

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@expenses @drahnr @chevdor @gilescope @HCastano @gui1117