Don't err on deactivated leaf during valiation. #3708
Conversation
eskimor
added
A2-insubstantial
node/core/backing/src/lib.rs
Outdated
| "Mpsc background validation mpsc died during validation- leaf no longer active?" | ||
| ); | ||
| } else { | ||
| tracing::debug!( |
There was a problem hiding this comment.
any reason to downgrade this to debug?
There was a problem hiding this comment.
I think that the closed mpsc is really an expected event, in case the leaf gets deactivated before the validation was able to finish. Which I guess can easily happen in practice (network delays and such) and should not trigger an error and alerting people. That's at least my understanding, if I am wrong - let's fix the bug instead 😅
There was a problem hiding this comment.
I guess it should not happen too often though ... if we want to keep an eye on that, a metric and alerts when it happens too often, in contrast to a higher logging level, would probably be more effective?
There was a problem hiding this comment.
oh - I just realized what you meant - no that still should be error, that was a copy paste error - thank you!
ordian
added
the
D3-trivial 🧸
* master: staking-miner: remove need of a file to pass the seed (#3680) Companion for 9619 (Private Events) (#3712) Fix Try-Runtime (#3725) XCM v2: Scripting, Query responses, Exception handling and Error reporting (#3629) Bump async-trait from 0.1.50 to 0.1.51 (#3721) allow some overhead in MERKLE_NODE_MAX_SIZE (#3724) Bump itertools from 0.10.0 to 0.10.1 (#3719) Bump tokio from 1.10.0 to 1.10.1 (#3717) Bump trybuild from 1.0.43 to 1.0.45 (#3713) Don't err on deactivated leaf during valiation. (#3708) Bump libc from 0.2.99 to 0.2.100 (#3703)
* Don't err on deactivated leaf during valiation. * Fix error level + formatting of unrelated code.
* Don't err on deactivated leaf during valiation. (#3708) * Don't err on deactivated leaf during valiation. * Fix error level + formatting of unrelated code. * Substrate update * Update node/core/backing/src/lib.rs Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: Robert Klotzner <eskimor@users.noreply.github.com> Co-authored-by: David <dvdplm@gmail.com>
This seems to be an expected event and should not trigger an error.