This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Further improved availability recovery #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eskimor
commented
Aug 24, 2021
•
eskimor
commented
- Don't fetch more chunks than needed, except when we have a non zero error rate.
- Properly track undead (soft cancelled) requests in order to make sure to always have enough "live" requests in flight.
- Add metrics that should be useful
eskimor
added
A0-please_review
ordian
reviewed
Aug 26, 2021
Lldenaurois
approved these changes
Aug 26, 2021
| while let Some(request_result) = | ||
| self.requesting_chunks.next().timeout(MAX_CHUNK_WAIT).await.flatten() | ||
| self.requesting_chunks.next_with_timeout(TIMEOUT_START_NEW_REQUESTS).await |
ordian
approved these changes
Aug 26, 2021
rphmeier
reviewed
Aug 27, 2021
| // 2. We request more chunks to make up for it | ||
| // 3. Bandwidth is spread out even more, so we get even more timeouts | ||
| // 4. We request more chunks to make up for it ... | ||
| let max_requests_boundary = std::cmp::min(N_PARALLEL, threshold); |
There was a problem hiding this comment.
side note: we should revisit N_PARALLEL. Perhaps this is something the lower-level networking code should care about and not the higher-level.
rphmeier
reviewed
Aug 27, 2021
| registry, | ||
| )?, | ||
| time_chunk_request: prometheus::register( | ||
| prometheus::Histogram::with_opts(prometheus::HistogramOpts::new( |
There was a problem hiding this comment.
Are the default buckets definitely good enough for this?
There was a problem hiding this comment.
Good point - I will check!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.