Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add tests and modify as_vec implementation #3715

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

Lldenaurois
Copy link
Contributor

Patch to address feedback left in #3626

Closes #3670

@Lldenaurois Lldenaurois added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 24, 2021
@Lldenaurois Lldenaurois added the B0-silent Changes should not be mentioned in any release notes label Aug 25, 2021
@ordian ordian removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Aug 25, 2021
@eskimor eskimor self-requested a review August 25, 2021 17:32
erasure-coding/src/lib.rs Outdated Show resolved Hide resolved
@eskimor eskimor merged commit 06f00a4 into paritytech:master Sep 6, 2021
@@ -23,3 +23,6 @@ serde = { version = "1.0.130", features = ["derive"] }

[target.'cfg(not(target_os = "unknown"))'.dependencies]
zstd = "0.6.0"

[dev-dependencies]
polkadot-erasure-coding = { path = "../../erasure-coding" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that still needed?

ordian added a commit that referenced this pull request Sep 6, 2021
* master:
  Add tests and modify as_vec implementation (#3715)
  Bump structopt from 0.3.22 to 0.3.23 (#3770)
  bump substrate and beefy (#3789)
  set `DisputesHandler` in initializer (#3788)
  Bump futures from 0.3.16 to 0.3.17 (#3742)
  Convert rococo chainspec to raw chainspec (#3785)
  feat/overseer: introduce closure init (#3775)
  comment out bridges runtime modules (broken) and update Rococo chain-spec (#3780)
  Add VoteLocking config (#3734)
  Enable disputes on rococo (#3764)
  XCM: Automatic Version Negotiation (#3736)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErasureChunk Proof needn't be Vec<Vec<_>>
4 participants