Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add logging for worker spawn failures #3827

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

pepyakin
Copy link
Contributor

No description provided.

@pepyakin pepyakin added the A0-please_review Pull request needs code review. label Sep 10, 2021
@pepyakin pepyakin added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 10, 2021
@ordian
Copy link
Member

ordian commented Sep 10, 2021

Isn't the error logged here:

tracing::warn!(target: LOG_TARGET, "failed to spawn a prepare worker: {:?}", err);
and
tracing::warn!(target: LOG_TARGET, "failed to spawn an execute worker: {:?}", err);

Or is it for test debugging?

@pepyakin
Copy link
Contributor Author

It is logged there indeed. However, the error is just an opaque Bind or Accept without actually giving any hint for what've happened. Introduction nested data into these error variants that would give more information is an option, however, I figured that it is a bit weird to juggle this data around whereas we just want to print what is the error.

@pepyakin pepyakin merged commit 7229ab8 into master Sep 10, 2021
@pepyakin pepyakin deleted the pep-spawn-worker-logging branch September 10, 2021 13:40
ordian added a commit that referenced this pull request Sep 14, 2021
* master:
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
ordian added a commit that referenced this pull request Sep 15, 2021
* master: (21 commits)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
  Do not expire HRMP open channel requests (#3543)
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants