Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix spelling #3845

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Fix spelling #3845

merged 3 commits into from
Sep 25, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 14, 2021

This PR is a backport of a commit from the 0.9.10 release allowing to fix the blocking spelling issues.

@chevdor chevdor added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 14, 2021
@chevdor chevdor marked this pull request as ready for review September 14, 2021 12:43
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done by a git subtree update to avoid conflicts in the future, but let's unblock whatever is blocking you :)

@chevdor
Copy link
Contributor Author

chevdor commented Sep 14, 2021

Thank you @tomusdrw. Please note however that this is NOT blocking me as I have the fix in the release branch anyway. I just wanted to backport it here to ensure it is kept in sync.
So if you see complications merging this PR, we can also drop it.

@tomusdrw
Copy link
Contributor

So if you see complications merging this PR, we can also drop it.

It's alright, should be resolved automatically anyway. I plan to update the bridges code this/next week anyway.

@ordian ordian requested a review from drahnr September 14, 2021 13:30
bridges/.config/lingua.dic Outdated Show resolved Hide resolved
@@ -101,6 +103,7 @@ parablock/MS
parachain/MS
parameterize/D
pallet_message_lane
plancks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

scripts/gitlab/lingua.dic Outdated Show resolved Hide resolved
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably remove \KeyPair`` from the allowed list.

I am also slightly puzzled why bridges has their own spellcheck config I assume this is because git-subtree?

@chevdor
Copy link
Contributor Author

chevdor commented Sep 14, 2021

@drahnr I did not dig into the meaning of those /MS but keypair/MS appears to accept only Keypair and not KeyPair. The detected mispelling comes from a comment refering to the type KeyPair. If you know how we can modify the dictionnary without the duplication, feel free to share and I can fix it. We can fix it now but I think those disctionnaries need a major cleanup anyway

@drahnr
Copy link
Contributor

drahnr commented Sep 21, 2021

bot merge

@ghost
Copy link

ghost commented Sep 21, 2021

Merge aborted: Checks failed for c087b06

@bkchr bkchr merged commit 8a75570 into master Sep 25, 2021
@bkchr bkchr deleted the wk-spelling-0cabddbb1 branch September 25, 2021 20:44
ordian added a commit that referenced this pull request Sep 28, 2021
* master: (24 commits)
  Added multisig in Rococo (#3873)
  Fix bin-substrate toml (#3939)
  Bump tracing from 0.1.27 to 0.1.28 (#3937)
  XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818)
  Bump libc from 0.2.101 to 0.2.102 (#3933)
  Do not compile `wasm_api` module when not needed. (#3934)
  Bump syn from 1.0.76 to 1.0.77 (#3932)
  Fix spelling (#3845)
  Bump tokio from 1.11.0 to 1.12.0 (#3910)
  Ignore `generate-bags` by dependabot (#3930)
  Update logging in paras_inherent (#3927)
  Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909)
  Remove BEEFY repo dependency (#3923)
  Substrate Companion for rust 1.54 (#3807)
  Fix broken links (#3919)
  update BaseXcmWegiht to match Kusama (#3911)
  add parachains pallets to Polkadot runtime (#3815)
  Add a `force_unfreeze` extrinsic to the disputes module (#3906)
  Add new rococo chainspec (#3905)
  Ensure all parachain configuration extrinsics are operational (#3912)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants